c302 integration fixes - Githubissues

openworm / sibernetic

This is a C++/OpenCL implementation of the PCISPH algorithm supplemented with a set of biomechanics related features applied to C. elegans locomotion

Other

361 stars 105 forks source link

c302 integration fixes #123

Closed lungd closed 6 years ago

pgleeson commented 7 years ago

@lungd is there anything here that you think is missing from the other PR: #133?

lungd commented 7 years ago

I need to call setup() (of the c302 config) with data_reader='UpdatedSpreadsheetDataReader. There should be an argument for that but it is still hardcoded. In this PR, how the 'values' list get generated inside C302NRNSimulation.run() is different.

After #133 got merged, we should think about some tests to check the values list. I think we can close/ignore this PR, for now. I can update it, so there are only changes for the argument and the values list, if needed.

pgleeson commented 6 years ago

@lungd I assume it's ok to close this now. Looking at consolidating the other PRs in the next day or two...

lungd commented 6 years ago

Indeed. These changes are included in #138