openworm / tracker-commons

Compilation of information and code bases related to open-source trackers for C. elegans
11 stars 12 forks source link

Insufficient rules on custom information to allow data merging #137

Open Ichoran opened 7 years ago

Ichoran commented 7 years ago

We don't have a precise specification for custom data. This is a problem if we want to be able to merge and split time series--what do you do with custom data?

I propose we include the following specification for custom fields in the data section:

This way the custom JSON data behaves the same way as the time series numeric data. (In particular, like the origin data where you can set a single origin for an arrayed time series.)

Ichoran commented 7 years ago

I have tried to write something along these lines in the documentation in #146 but it's not yet implemented by readers.

MichaelCurrie commented 7 years ago

I really like this idea. For now the Python parser just drops any custom fields as soon as the file is read, leaving it to other more specialized readers to handle the custom fields.

Being able to merge them in a way that makes sense would make the readers more useful for labs, and would mean they wouldn't have to specialize the readers at all, they could just deal with the custom fields they are interested in once the object is in memory.

So now all that's left is implementing it!

Ichoran commented 7 years ago

This is fully implemented in Scala (save for bugs) in #152