search

openworm / tracker-commons

Compilation of information and code bases related to open-source trackers for C. elegans
11 stars 12 forks source link

Origin specification is complex #138

Closed Ichoran closed 7 years ago

Ichoran commented 7 years ago

Most things, like centroids, can either be there or not. If there, they're all there (in an array). But origins are allowed to exist as a single point that applies to all values in a time series.

This is somewhat helpful for data compaction. But it's also a complication for implementations, especially since the data is uninterpretable, if it has origins, unless you take origins into account.

Maybe we should remove this and make origins be the same dimensionality as the time series, without exception. (If yes, we can also simplify rules about custom JSON in the same way.)

Ichoran commented 7 years ago

I propose that we mandate that origins be specified in full or not at all, even if it's just the same number over and over again. The reason is that minimal readers must handle origins, unlike custom data, so they must understand these different options. They shouldn't have to.

Ichoran commented 7 years ago

The specification is simplified in #146 but software is not fully updated yet. The Scala version was partially updated along with the perimeter implementation #136

MichaelCurrie commented 7 years ago

We agreed to simplify this at the meeting on 16 March. As @Ichoran says, now it's a matter of implementing...

Ichoran commented 7 years ago

This is fully implemented in Scala as of #152

MichaelCurrie commented 7 years ago

I believe this is now handled at some point somewhat before 44df1c5