search

openworm / tracker-commons

Compilation of information and code bases related to open-source trackers for C. elegans
11 stars 12 forks source link

Worm ID can be a number, but this raises ambiguities #142

Closed Ichoran closed 7 years ago

Ichoran commented 7 years ago

Worm IDs are allowed to be either numbers or strings. But what if the two are mixed?

Is "id":0 the same as "id":"0"? What about "id":0.0?

We should either carefully specify exactly what the equivalence is, or we should allow only string IDs (where there should be no ambiguity).

MichaelCurrie commented 7 years ago

I'd be in favour of allowing only string IDs. If someone has the convention that all their worms use integer IDs, they are just as unambiguous if converted for WCON purposes into strings, so no problem there.

Using a float to identify your worms is the worst data practice I've ever heard, so let's not support that :)

Ichoran commented 7 years ago

Specification is updated in #146 but software is not updated yet.

MichaelCurrie commented 7 years ago

Tests were updated by @Ichoran with d27f2bec3ce2809c00adb2d8a67e5d1199d8dc42.

MichaelCurrie commented 7 years ago

It's also a rule in the schema, which is optionally used because the current schema validator used (jsonschema) is very slow on large files.

Nothing else needed here; I will close this.