openworm / tracker-commons

Compilation of information and code bases related to open-source trackers for C. elegans
11 stars 12 forks source link

Scala implementation should use a proper JSON parser #69

Closed Ichoran closed 8 years ago

Ichoran commented 8 years ago

Right now the Scala implementation uses a JSON parser defined in FastParse. While FastParse is fast for a general parser combinator, it is not fast compared to a production-level JSON parser like Jawn.

Therefore, the Scala implementation should switch to a real JSON parser. This should speed up parsing by 2-4x (at least the JSON part of it).

Ichoran commented 8 years ago

Resolved by https://github.com/openworm/tracker-commons/pull/89

(Incidentally, the speedup was closer to 10x than 2-4x.)

Ichoran commented 8 years ago

Actually resolved by https://github.com/openworm/tracker-commons/pull/90 - I closed the other one by mistake.