search

openworm / tracker-commons

Compilation of information and code bases related to open-source trackers for C. elegans
11 stars 12 forks source link

Issue 83 - Fix offset / centroid handling in Scala #95

Closed Ichoran closed 8 years ago

Ichoran commented 8 years ago

Reworked how offsets are handled in the Scala code and data structures. Also wrote test files to verify that offsets are being interpreted properly.

Ichoran commented 8 years ago

@MichaelCurrie - Could you verify that the test files I've added specify equivalent spine points, and that the two with centroids specify the same centroids? I think they do, and the Scala code thinks so also, but we could be mistaken.

If it looks good, please merge (assuming the CI looks okay).

Ichoran commented 8 years ago

Hang on, don't merge it yet. Somehow it's trying to merge the entire Jsonal patch as well. Let me know if you agree about the files, and I'll clean up the merge history.

Ichoran commented 8 years ago

@MichaelCurrie - I merged this anyway since the tests look good and I want to keep the Scala implementation working, but please let me know if you think the test files need to be modified.

Ichoran commented 8 years ago

Resolves https://github.com/openworm/tracker-commons/issues/83