Add better tests for screenshot commands - Githubissues

openwpm / OpenWPM

A web privacy measurement framework

https://openwpm.readthedocs.io

Other

1.33k stars 313 forks source link

Add better tests for screenshot commands #160

Open englehardt opened 6 years ago

englehardt commented 6 years ago

We currently have two built-in commands which take screenshots:

save_screenshot which takes viewport screenshots
screenshot_full_page which takes a screenshot of the entire visible page

The tests for these commands, located here, simply check if the screenshots are generated and are not entirely blank.

These tests can be improved in a number of ways:

Check size of viewport and full page screenshots
Generate a test page with certain colors at known locations and verify that those colors are found at the expected locations in the screenshots.

Akhila499 commented 4 years ago

Hi... I am Akhila, Outreachy applicant for March 2020. May I start working on this? Is this still open for contribution? @englehardt I am new to open source community. Can you please guide me on getting up to speed with this issue?

Thanks