search

openwrt / actions-shared-workflows

4 stars 12 forks source link

CI: tools: switch to use the latest macOS for x64 #20

Closed BKPepe closed 2 months ago

BKPepe commented 2 months ago

Recently, macOS runner on GitHub was migrated from macOS 12 (Monterey) to macOS (14), but with this switch macos-latest is now pointing to arm64 build, which is currently failing while building OpenWrt.

E.g. error log:

Checking 'working-make'... failed.
Details: https://github.com/openwrt/openwrt/actions/runs/8834725561/job/24257119788?pr=15269

Previously with the macOS 12, we were using x64 builds, so stick for it, for now.

[1] https://github.blog/changelog/2024-04-01-macos-14-sonoma-is-generally-available-and-the-latest-macos-runner-image

Available images can be found here: https://github.com/actions/runner-images?tab=readme-ov-file#available-images

robimarko commented 2 months ago

I dont think there is need for pinning to x86, they switched to ARM64 as they have a lot more of them

BKPepe commented 2 months ago

Yeah, they did. I did not want to use arm for Macbook, thus I stick to Intel. Not sure, if OpenWrt could be compiled for arm64, but maybe who knows. :)

Anyway, this PR is no longer required as recently merged commit https://github.com/openwrt/actions-shared-workflows/commit/cdc2a2569f2675cd60c38ebd3b925f6ce8ef1b6a fixed it more correctly. It is using brew, thus it was required to change the paths.

Closing.