openwrt / actions-shared-workflows

4 stars 14 forks source link

build: multi-arch-test-build: support apk in artifacts #26

Closed Habbie closed 2 days ago

Ansuel commented 4 days ago

Mhh do we need the index.json ?

Thanks for taking care!

Habbie commented 4 days ago

Mhh do we need the index.json ?

I don't know! at least it's small :)

Ansuel commented 4 days ago

I mean why it was added in the first place? ahaahahah

Habbie commented 4 days ago

I mean why it was added in the first place? ahaahahah

I'm not even sure where it comes from

Habbie commented 4 days ago

but, if you're asking why I added it, I added it because I saw it in the cp -v output :)

Ansuel commented 4 days ago

@Habbie if you are ok with this and you don't get annoyed I would ask you

  1. Drop the index.json
  2. split this in 2 commits one for the -v change and one for the apk...

Also would prefer to have a more explicit pattern for ipk or apk (instead of using [ia])

Also any chance you can add a commit description (even repetition of title with different words) and signed off by tag?

Habbie commented 4 days ago

Also would prefer to have a more explicit pattern for ipk or apk (instead of using [ia])

if you mean *.ipk *.apk, the problem with that is that one of them will generate an error. that's why I did [ia]

Habbie commented 3 days ago

if you are ok with this and you don't get annoyed I would ask you

done, signed off, added a few words to the second commit message

Ansuel commented 2 days ago

(improved this a bit, thanks a lot for this) (ignore the multiple push, I was improving one of our maintainer scripts and just used this as test)