openwrt / asu

An image on demand server for OpenWrt based distributions
https://sysupgrade.openwrt.org
GNU General Public License v2.0
333 stars 84 forks source link

config: enable use of new setup.sh in snapshots #1076

Closed efahl closed 2 weeks ago

efahl commented 2 weeks ago

Run the setup.sh in the "new format" snapshot docker images prior to running any make commands.

@aparcar , probably need to do this soon as there are a lot of reports piling up on FS and elsewhere about "make info" not working, this is the fix.

codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 90.79%. Comparing base (5e65dec) to head (6170715). Report is 142 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1076 +/- ## =========================================== + Coverage 80.75% 90.79% +10.03% =========================================== Files 15 14 -1 Lines 977 1108 +131 =========================================== + Hits 789 1006 +217 + Misses 188 102 -86 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

aparcar commented 2 weeks ago

Thanks, I solved It slightly differently since your PR would break any server not running a squid

https://github.com/openwrt/asu/commit/b7e3baab3fcd765806acc7e537518354f66bcd4e

efahl commented 2 weeks ago

Excellent. I've got local and remote tests running with your changes now, looks good!