openwrt / asu

An image on demand server for OpenWrt based distributions
https://sysupgrade.openwrt.org
GNU General Public License v2.0
310 stars 77 forks source link

improve the settings in /etc/config #31

Closed FreifunkUFO closed 7 years ago

FreifunkUFO commented 7 years ago

on https://github.com/openwrt/luci/blob/master/applications/luci-app-attendedsysupgrade/luasrc/view/attendedsysupgrade.htm#L90 there is a

settings[0].

please change it to a better openwrt standard

FreifunkUFO commented 7 years ago

for instance that way:

root@74-57:~# cd /etc/config/ root@74-57:/etc/config# cat asu

config settings 'update' option server 'https://betaupdate.libremesh.org'

root@74-57:/etc/config# uci get asu.update.server https://betaupdate.libremesh.org root@74-57:/etc/config#

aparcar commented 7 years ago

Do you have a better idea for the names? config setttings "update" looks a bit odd to me.

FreifunkUFO commented 7 years ago

you could use:

config settings 'settings'

dangowrt commented 7 years ago

On Thu, Aug 10, 2017 at 08:59:54AM +0000, FreifunkUFO wrote:

you could use:

config settings 'settings'

imho that'd make it even worse.

i suggest:

config updateserver 'beta'
    option name 'beta'
    option url 'http://betaupdate.libremesh.org/'
    option selected '1'

config updateserver 'official'
    option name 'official'
    option url 'http://update.openwrt.org/'

config updateclient
    option whatever '1'
aparcar commented 7 years ago

looks good to me, I'll set this up

aparcar commented 7 years ago

merged upstream https://github.com/openwrt/luci/commit/415d3aeb164754e9e16408f95d6e5ff94b0fdf62 https://github.com/openwrt/packages/commit/bc0a03071e24fddc118186f9aced64840a77d80e

currently only one update server is supported. If you feel the need of a dropdown menu for a large variety of update servers please open a separate issue