change the config file and settings

[FreifunkUFO]

the naming of the settings is confusing (upgrade vs. update).

[FreifunkUFO]

you already did some changes: https://github.com/aparcar/luci/commit/9e1728cd625b841cb35de5191d82639f7bd52286

[FreifunkUFO]

i think that "rename url to server_url" is not needed, because "url" is coupled to value "updateserver" already.

` root@211-41:~# uci get attendedsysupgrade.updateserver.url https://betaupdate.libremesh.org

`

[FreifunkUFO]

would be nice to change the filename 🥇 because project/packagename is with "-", so the filename should also have a "-". other configs already have "-" or "_"

root@211-41:~# cat /etc/config/ attendedsysupgrade freifunk-widgets olsrd batman-adv horst olsrd6 dhcp luci profile_leipzig dropbear luci_olsr rpcd firewall luci_splash system freifunk luci_splash_leases ubootenv freifunk-gwcheck luci_statistics ucitrack freifunk-mapupdate meshkit uhttpd freifunk-policyrouting meshwizard wireless freifunk-watchdog network

[FreifunkUFO]

please honour ticket https://github.com/aparcar/gsoc17-attended-sysupgrade/issues/64 . would be nice to make it now, when config is even changing.

[FreifunkUFO]

the new feature "search on opening the view without clicking" is mad. nowhere else on menu of luci-components there is an internet-access without explicitly asking. would be nicer to see the url/description of the choosed server near the search-button ( or -in the future - a list of possible servers #64 )

[FreifunkUFO]

next detail: if you "rename updateserver to upgradeserver" you should even more simpily the config, and name it just "server" :-o

[aparcar]

the new feature "search on opening the view without clicking" is mad

@jow- is that mad? I remember we discussed once an upgrade check adding a banner to the login view in case there is an upgrade. That would require "search on opening" as well.

[aparcar]

would be nice to change the filename 🥇

at some situations a dash does not work, we decided to unify it to attendedsysupgrade instead of a variation of attended_sysupgrade, attended-sysupgrade and finally attendedsysupgrade

[aparcar]

i think that "rename url to server_url" is not needed, because "url" is coupled to value "updateserver" already.

this should be possible

generally, please open single issues per proposed change as these may result in individual discussions :) thanks

[FreifunkUFO]

its done here https://github.com/openwrt/luci/commit/e8259af9ce7cb442865d583d2c5b73acff1691ce#diff-b5fba9ff24d0045d1377a05a46b32f68

[FreifunkUFO]

a wrong server was set: https://github.com/aparcar/packages/blob/1864a76e9cd34020bf10b59e3b794beda02a6186/utils/rpcd-mod-attendedsysupgrade/files/attendedsysupgrade.defaults

[aparcar]

that was requested by @jow-

[FreifunkUFO]

new uci options: https://github.com/openwrt/packages/pull/5053

[aparcar]

New config options are upstream