openwrt / asu

An image on demand server for OpenWrt based distributions
https://sysupgrade.openwrt.org
GNU General Public License v2.0
321 stars 80 forks source link

Revert "Allow custom UCI defaults: False" #711

Closed hashcan closed 8 months ago

hashcan commented 8 months ago

Hello world, I would like to request to revert the commit that changed the "Allow custom UCI defaults" option from True to False for the https://sysupgrade.openwrt.org website. This option allows us to use a custom uci-default script to configure the image after flashing. This is very useful for setting up things like network, firewall, wireless, and other settings that are specific to our devices and environments. as I use the "don't keep the current configurations" option to flash the image, I rely on the custom uci-default script to set up the device automatically. Without this option, we have to manually configure the device after flashing, which is tedious and error-prone.

Rinat84 commented 8 months ago

ImmortalWrt this feature works

aparcar commented 8 months ago

I set the according env variable which I forgot in the last deployment, enjoy.

AlanFinotty commented 2 months ago

https://github.com/openwrt/asu/blob/main/asu/config.py#L14

It is set to "False"

hashcan commented 2 months ago

@aparcar can you please switch it on again ?

hansenjt91 commented 2 months ago

How does this keep getting turned off?