search

openwrt / asu

An image on demand server for OpenWrt based distributions
https://sysupgrade.openwrt.org
GNU General Public License v2.0
321 stars 80 forks source link

Max ROOTFS_PARTSIZE clamped to unrealistic value #826

Closed efahl closed 4 months ago

efahl commented 4 months ago

Doing some testing, requested an image from the ASU build server with a 256 MB root partition using this request

{
    "client": "owut/24.0.0",
    "target": "x86/64",
    "profile": "generic",
    "version": "SNAPSHOT",
    "filesystem": "ext4",
    "rootfs_size_mb": 256
}

and it fails with 

Status: 400
Detail: 256 is greater than the maximum of 100 - 'rootfs_size_mb'

I build images all the time with 512MB root partitions, and the default for all builds in config/Config-images.in is 104 with two exceptions: target mediatek (448) and loongarch64 (232). Having it limited to 100 seems incorrect, maybe 1000/1024 would be a better ceiling?

I think the culprit is here: https://github.com/openwrt/asu/blob/101831b3a04d7af780f0540f52082873dd1933d8/asu/asu.py#L38 but could be here: https://github.com/openwrt/asu/blob/101831b3a04d7af780f0540f52082873dd1933d8/misc/config.py#L17 (or both?)