openwrt / asu

An image on demand server for OpenWrt based distributions
https://sysupgrade.openwrt.org
GNU General Public License v2.0
332 stars 83 forks source link

test_api: verify request hash with different package ordering #912

Closed efahl closed 3 months ago

efahl commented 3 months ago

Add test cases with both diff_packages true and false, with the input package list both unordered and sorted. Request hash must be identical regardless of package list order.

Signed-off-by: Eric Fahlgren ericfahlgren@gmail.com

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 85.46%. Comparing base (5e65dec) to head (88098a3). Report is 80 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #912 +/- ## ========================================== + Coverage 80.75% 85.46% +4.71% ========================================== Files 15 14 -1 Lines 977 991 +14 ========================================== + Hits 789 847 +58 + Misses 188 144 -44 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

aparcar commented 3 months ago

@efahl please fix the one failing checksum (8731372f84b0022c070e6127bad24eb2)

efahl commented 3 months ago

please fix the one failing checksum

👍🏼 I messed up my VM and have been recovering all morning, just got the tests to run again...