search

openwrt / docker

Docker containers of the ImageBuilder and SDK
GNU General Public License v2.0
463 stars 76 forks source link

Dockerfile.base: add aria2 #95

Closed PolynomialDivision closed 1 year ago

PolynomialDivision commented 1 year ago

OpenWrt now supports aria2c: https://github.com/openwrt/openwrt/commit/d391236269314a759acb7dfb7ec01ccaa0e0b32c

PolynomialDivision commented 1 year ago

ping @Ansuel

ynezz commented 1 year ago

OpenWrt now supports aria2c:

Does this necessarily mean, that everyone should start using it? BTW is it really ready for prime time yet? Shouldn't it be first enabled in CI container to see how it goes? IIUC then the purpose of base containers is well, being minimal, so if that is still the case, shouldn't the removal of similar tools, wget and curl be considered as well?

PolynomialDivision commented 1 year ago

Okay, lets postpone it. :)

aparcar commented 1 year ago

Is aria2 an advantage regarding speed to the current solution?

Ansuel commented 1 year ago

@aparcar depends in theory yes since it's a much more advanced download tool... so for cdn usage it should make download near instant and should autoselect the best mirror.

aparcar commented 1 year ago

I reworked the Dockerfiles so they depend on the Buildbot images we're using. This PR should therefore add the tool to the Buildbot images instead.

Ansuel commented 1 year ago

@aparcar btw in having fun with CI on the main repo, in an effort to reduce the image to small stuff, I notice we can use minideb container instead of full debian https://github.com/Ansuel/openwrt/commit/2a942ed2982692f21e507f620ce5b1687f22c76f

It's widely used so I can be an idea.