search

openwrt / firewall4

[MIRROR] OpenWrt nftables firewall
https://git.openwrt.org/?p=project/firewall4.git;
17 stars 13 forks source link

Is this repo actually used for PRs? #39

Closed jonathanunderwood closed 1 month ago

jonathanunderwood commented 1 month ago

There are currently 9 PRs open, with the eearliest being > 9 months old, and seemingly no response from @jow-. This makes me wonder if this is actually a viable route to contribute to fw4? @jow- (or anyone else with commit access) any chance you could provide some clarification on your preferred mechanism for contributing changes to fw4?

jow- commented 1 month ago

Yes it is. Unfortunately @brada4's PR descriptions are often too terse to understand, some open PRs are wip and/or obsoleted by later PRs and/or changed from time to time.

Due to that, merging those has to wait until I have more spare time at my hand to actually review and test them.

brada4 commented 1 month ago

Turnover rate could wish better. https://github.com/openwrt/openwrt/issues/12112 was reported against then still supported rev 21, still not in stable release, but I appreciate e.g 101% re-factoring of https://github.com/openwrt/firewall4/pull/26

jonathanunderwood commented 1 month ago

Thanks @jow- - fully understand the time-starved aspect, but it's reassuring that the PRs are in the right venue!