do not update the browser's URL on a simple page load

openwrt / firmware-selector-openwrt-org

The OpenWrt Firmware Selector! Quickly find firmware for your device and build custom ones online!

Creative Commons Zero v1.0 Universal

49 stars 22 forks source link

do not update the browser's URL on a simple page load #21

Open Lanchon opened 3 months ago

Lanchon commented 3 months ago

when you open a link such as this one:

https://firmware-selector.openwrt.org/?target=ipq40xx%2Fgeneric&id=linksys_whw03v2

the page immediately rewrites browser's URL adding version=23.05.4& to it. this is a very minor annoyance, but IMHO the page should only modify the browser's URL if the user actually selects something. please consider fixing this.

mwarning commented 1 month ago

The missing version in the link is actually an oversight that was fixed. But I understand that it might be behavior against the norm/expectation. I will fix it if does not complicate the code too much.