openwrt / gh-action-sdk

GitHub CI action to build packages via SDK
29 stars 47 forks source link

Fix build errors, add ARTIFACTS_DIR and FEED_DIR, add CI #10

Closed jefferyto closed 2 years ago

jefferyto commented 2 years ago

I debated whether to do so much in one PR, but I think it makes sense to group these:

jefferyto commented 2 years ago

Maybe actions need to be enabled for the repo to run the CI.

ynezz commented 2 years ago

Maybe actions need to be enabled for the repo to run the CI.

image image

Indeed, this is interesting, I don't see anything which would prevent the actions from running. You're not 1st time contributor either and I don't see anything in the UI either.

ynezz commented 2 years ago

Should be ok now, please rebase and let's see.

jefferyto commented 2 years ago

@ynezz thanks!

jefferyto commented 2 years ago

@aparcar @ynezz any comments?

ynezz commented 2 years ago

@aparcar @ynezz any comments?

please rebase and let's see.

@jefferyto so can you rebase? I'm still seeing that Add CI commit of yours.

image

jefferyto commented 2 years ago

The "Add CI" commit is part of this PR, it's not in master yet.

I had already rebased earlier - you would like me to rebase again?

jefferyto commented 2 years ago

Oh you manually committed that commit, okay...

jefferyto commented 2 years ago

Rebased.

ynezz commented 2 years ago

tag v5.2 created

aparcar commented 2 years ago

Thank you both

jefferyto commented 2 years ago

Thanks - can update the v5 tag as well?

aparcar commented 2 years ago

Done