search

openwrt / gh-action-sdk

GitHub CI action to build packages via SDK
30 stars 48 forks source link

Dot not fail when package hash configuration is skip #18

Open EkkoG opened 1 year ago

EkkoG commented 1 year ago

When the package skips the hash check, SDK will alert a WARM log, and the action will exit cause the WARM https://github.com/openwrt/gh-action-sdk/blob/74b0fee6a8bbd43306ececc50698637f946ddaf8/entrypoint.sh#LL75C28-L75C28

I think it should pass when package config skip hash check

EkkoG commented 1 year ago

How read PKG_HASH from the Makefile before building?

aparcar commented 1 year ago

Do you mean like after updating the version, how to get the new PKG_HASH?

spvkgn commented 1 year ago

This issue is still exist. When Makefile contains PKG_HASH:=skip the action fail with Package HASH check failed message. Maybe reopen?

qwerttvv commented 7 months ago

Has the problem been solved?

@EkkoG @spvkgn

I've opened a new issue. https://github.com/openwrt/gh-action-sdk/issues/35

EkkoG commented 1 day ago

Do you mean like after updating the version, how to get the new PKG_HASH?

@aparcar I want to read PKG_HASH before build to check if PKG_HASH's value is skip, if is skip, remove some entry from badhash_msg