search

openwrt / gh-action-sdk

GitHub CI action to build packages via SDK
29 stars 47 forks source link

Always return artifacts, group secondary log lines #30

Closed jefferyto closed 10 months ago

jefferyto commented 10 months ago

"Delay package build error exit, remove -j1 rebuild" is the main commit in this group. Having log files available makes it much easier to diagnose build errors that only occur during CI, e.g. https://github.com/openwrt/packages/pull/22411. Please see the commit message for the full reasoning on removing the rebuild.

On grouping log lines, my preference would have been to group the package build log output as well, but there currently isn't a way to group log lines and have it be expanded by default (for the case of a build error), so this only groups "secondary" log lines.

aparcar commented 10 months ago

Very cool idea to group things, @Ansuel we should use that more.

Thanks for your work!

aparcar commented 10 months ago

It's now tagged as v6