run init scripts through shfmt

openwrt / gh-action-sdk

GitHub CI action to build packages via SDK

29 stars 47 forks source link

run init scripts through shfmt #4

Closed neheb closed 2 years ago

neheb commented 3 years ago

Based on the quilt check above.

Signed-off-by: Rosen Penev rosenp@gmail.com

aparcar commented 2 years ago

You should pass the NO_SHFMT_CHECK here as well.

neheb commented 2 years ago

Done.

jefferyto commented 2 years ago

Every packages CI run now includes the error message:

find: 'shfmt': No such file or directory

I believe openwrt/sdk is based on debian:latest (bullseye), but shfmt is only available for testing and unstable. Even if it was available, you would need to install it in the image in order to use it.

Edit: It might even be debian:10, not latest.

aparcar commented 2 years ago

@jefferyto @neheb mind creating a PR?

neheb commented 2 years ago

Nope. Needs testing. My bullseye setup doesn't have it.

edit: https://packages.debian.org/search?searchon=names&keywords=shfmt

edit2: maybe NO_SHFMT_CHECK should be passed by default. Not sure where though...