search

openwrt / gh-action-sdk

GitHub CI action to build packages via SDK
29 stars 47 forks source link

Misc fixes for build script #8

Closed moetayuko closed 2 years ago

moetayuko commented 2 years ago
  1. Don't advertise optional features when building
    • ./scripts/feeds install -d y activates all optional features including these default to n in Kconfig, which is undesired in most cases.
    • 24b910d72772eda61a07d35bdccdfbf7fd20d133 dropped the switch for individual package builds two years ago. Drop it for all-package builds as well to ensure consistency and avoid undesired behaviors.
  2. Move all custom feeds after default feeds
    • Feeds are downloaded and checked out sequentially. Makefiles from custom feeds may include the ones provided by default feeds (e.g. luci.mk), and such packages will fail to install without them. Hence, default feeds should come before custom feeds.
    • (PS: issue observed with 21.02 but not with 22.03 and snapshot, probably fixed on build system side at some point after 21.02 release)
  3. Explicitly install extra feeds
    • Now that packages from extra feeds only get installed when required by ones from other feeds, but we might want to directly build them.
moetayuko commented 2 years ago

@ynezz @aparcar Any chances of getting this merged?

aparcar commented 2 years ago

Looks good, tja ja for your work and patience