openwrt / iwinfo

[MIRROR] Library for accessing wireless device drivers
https://git.openwrt.org/?p=project/iwinfo.git;
GNU General Public License v2.0
6 stars 17 forks source link

Add DeviceID for Mediatek MT7916AN on AW7916-NPD #2

Closed NotANormalNerd closed 1 year ago

NotANormalNerd commented 1 year ago
Ansuel commented 1 year ago

@NotANormalNerd thanks for the pr.

Can you follow the pattern used here?

https://github.com/openwrt/iwinfo/commits/master/devices.txt and squash the 2 commit?

NotANormalNerd commented 1 year ago

I will try to figure out the pattern and squash my commits 😄

Thanks for the quick feedback.

trippleflux commented 1 year ago

@NotANormalNerd Hmm, In my installed AW7916-NPD, I only detected this one instance :

407 [    2.457796] pci 0000:05:00.0: [14c3:7906] type 00 class 0x028000
408 [    2.463848] pci 0000:05:00.0: reg 0x10: [mem 0x6000000000-0x60000fffff 64bit pref]
409 [    2.467753] pci 0000:05:00.0: reg 0x18: [mem 0x50700000-0x50707fff 64bit]
410 [    2.474567] pci 0000:05:00.0: reg 0x20: [mem 0x6000100000-0x6000100fff 64bit pref]

Hwinfo

pci device: name = 0000:05:00.0
    path = /devices/pci0000:00/0000:00:1c.0/0000:02:00.0/0000:03:07.0/0000:05:00.0
    modalias = "pci:v000014C3d00007906sv000014C3sd00007906bc02sc80i00"
    class = 0x28000
    vendor = 0x14c3
    device = 0x7906
    subvendor = 0x14c3
    subdevice = 0x7906
    irq = 174
    res[0] = 0x6000000000 0x60000fffff 0x14220c
    res[2] = 0x50700000 0x50707fff 0x140204
    res[4] = 0x6000100000 0x6000100fff 0x14220c
    config[64]
36: PCI 500.0: 0280 Network controller
  [Created at pci.386]
  Unique ID: Ddhb.2l6miJlj0V1
  Parent ID: Phdb.PRpwMa6hOY8
  SysFS ID: /devices/pci0000:00/0000:00:1c.0/0000:02:00.0/0000:03:07.0/0000:05:00.0
  SysFS BusID: 0000:05:00.0
  Hardware Class: network
  Model: "MEDIATEK Network controller"
  Vendor: pci 0x14c3 "MEDIATEK Corp."
  Device: pci 0x7906 
  SubVendor: pci 0x14c3 "MEDIATEK Corp."
  SubDevice: pci 0x7906 
  Driver: "mt7915e"
  Driver Modules: "mt7915e"
  Memory Range: 0x6000000000-0x60000fffff (ro,non-prefetchable)
  Memory Range: 0x50700000-0x50707fff (rw,non-prefetchable)
  Memory Range: 0x6000100000-0x6000100fff (ro,non-prefetchable)
  IRQ: 174 (10496 events)
  Module Alias: "pci:v000014C3d00007906sv000014C3sd00007906bc02sc80i00"
  Config Status: cfg=new, avail=yes, need=no, active=unknown
  Attached to: #42 (PCI bridge)

So there is no "0x14c3 0x7909 0x14c3 0x7909", only "0x14c3 0x7906 0x14c3 0x7906"?.

NotANormalNerd commented 1 year ago

@trippleflux Yes, you are right, I have the same output. My first commit was wrong, typo.

@Ansuel I updated the commit message and squashed the commits. Should be fine now.

Ansuel commented 1 year ago

@NotANormalNerd commit description is still missing.

trippleflux commented 1 year ago

@NotANormalNerd I was just trying to be helpful, because I am not a hardware expert, probably I am just missed something.

OT : For AW7916-NPD for 2,4 GHz, is it true by spec they lock it up at 17 dBm?.

@Ansuel, please pardon my Off topic this time.

NotANormalNerd commented 1 year ago

@trippleflux No you were absolutely right. I am also no hardware expert just trying to contribute my bit to OpenWRT.

For the question about the power output: looking at the shop page of AsiaRF it seems that for 11ac & 11ax at HE40 they seem to have limited it to 17dBm: https://asiarf.com/product/wi-fi-6e-mini-pcie-module/

image

I am personally still a bit confused about the second onboard chip, since they have a Filogic 630 (MT7916AN) and a Filogic 830 (MT7976DN) onboard for the offloading. But it seems the 830 is doing the physical stuff and the 630 is doing the logical stuff. Either way: great chip.

trippleflux commented 1 year ago

Yes, I think so a great chip, I should read chipset specifications more often.

Reaches 400-700 Mbps download 1,5 meters from it, with openspeedtest with my three tripple-band antenna even not properly aligned and lined up (they are horizontally lined up). Overall satisfied even with locked 17 dBm @ 2.4 GHz.

NotANormalNerd commented 1 year ago

@Ansuel Should be ready now.