search

openwrt / luci

LuCI - OpenWrt Configuration Interface
Apache License 2.0
6.28k stars 2.51k forks source link

theme-bootstrap: no space between tab-description and first value #298

Closed chris5560 closed 9 years ago

chris5560 commented 9 years ago

If using a tab description there is not enough space left to the first value. Have a look on attached picture. Tab description touch start button.

bildschirmfoto - 18 01 2015 - 20 18 08

legendtang commented 9 years ago

The latest luci-app-privoxy package added three <br> beneath the text. It should works well now.

h dy0h0k0l 4vm 7 w_pt

This issue should close now.

chris5560 commented 9 years ago

Hi Legend, I opened this issue because it's only a problem of bootstrap-theme, so of bootstrap.css. I'm not familiar with css, so I can't fix it. Inside luci-app-privoxy and luci-app-ddns I build a workaround by inserting three
. It's a workaround not a fix.

legendtang commented 9 years ago

Hello chris5560, Sorry for the misinterpretation. I think I should be able to fix them with a pull request. That means I should remove those <br /> in these two luci-apps at the same time. Is that right?

chris5560 commented 9 years ago

Legend, if you could fix the bootstrap.css I will modify both apps. I had some other minor changes for those apps pending for distribution. So all for those apps could be done at once. Thanks Christian

legendtang commented 9 years ago

Hi Christian, I have fixed just now. It's because the form .cbi-tab-descr has no definition in CSS. Please remove those br as soon as possible.

Thanks Legend Tang

chris5560 commented 9 years ago

Fixed. Thanks.