openwrt / luci

LuCI - OpenWrt Configuration Interface
Apache License 2.0
6.44k stars 2.55k forks source link

luci-app-https-dns-proxy: ECS no longer supportedby https-dns-proxy #4195

Closed mikeasolo closed 4 years ago

mikeasolo commented 4 years ago

Configuring EDNS client subnet" casuses https-dns-proxy to crash with the error message "Unknown state!" and an exit code of 1.

This is expected behavior per the attached issue after ECS support was removed

https://github.com/aarond10/https_dns_proxy/issues/76

"This option has been removed from the latest version as it had no effect.

The ECS command-line flag was supported by Google in their JSON API but it was never well supported elsewhere and was necessary there because EDNS could not be expressed via the JSON API. Now that we're using the binary proptocol (RFC8484), you should look to configure that with a recursive DNS resolver.

dnsmasq I believe supports this via the --add-subnet option." by " aarond10 commented on Feb 22"

feckert commented 4 years ago

@stangri Can you comment on that?

stangri commented 4 years ago

@stangri Can you comment on that?

Confirm broken, I think I should fix it in the init script first and remove the fields from the luci app after.

PRs for init script: https://github.com/openwrt/packages/pull/12596, https://github.com/openwrt/packages/pull/12597, https://github.com/openwrt/packages/pull/12598.

feckert commented 4 years ago

@stangri thanks for your work