openwrt / luci

LuCI - OpenWrt Configuration Interface
Apache License 2.0
6.38k stars 2.53k forks source link

Existing dark themes and/or dark variant of existing ones #4578

Closed evelikov closed 4 years ago

evelikov commented 4 years ago

For a while I've been looking for a dark theme.

The only one I could find being darkmatter [1]. It is missing a proper package and might be having some odd issues. Sadly there's some friction [2] so it seems unlikely to have it upstream soon.

Do you know any up-to date dark themes? Would the luci team consider making a dark variant for any of the existing ones?

Thanks in advance

[1] https://github.com/apollo-ng/luci-theme-darkmatter [2] https://github.com/apollo-ng/luci-theme-darkmatter/issues/18

feckert commented 4 years ago

From my perspective I would like to have 2 themes.

The other customization and properties changes, like colour and other CSS gimmicks could be controlled by css files. As already considered in the P/R.

The problem with the diffrent themes is that once they are checked into the Luci feed, nobody cares about them. Currently for example the theme luci-theme-matrial is not usable as I know by my last tests some time ago in the master does not support the ACL changed that were recently added into master.

evelikov commented 4 years ago

I fully agree - dark variant/mode can be done completely via css "prefers-color-scheme". An attribute handled by all modern browsers.

jow- commented 4 years ago

There is no dark theme atm

teohhanhui commented 3 years ago

I've created a UserCSS for luci-theme-bootstrap dark version: https://github.com/teohhanhui/openwrt-luci-bootstrap-dark

If the maintainers are okay with it, I'd like to send a PR. IMO this approach is low maintenance (just 100 lines of CSS, and they should be co-located with the corresponding style rules for the light theme), but with high visibility (enabled by default with prefers-color-scheme, so any issues would be reported by users).