search

openwrt / luci

LuCI - OpenWrt Configuration Interface
Apache License 2.0
6.38k stars 2.53k forks source link

luci-theme-bootstrap: Buttons at Status/Overview/Associated Stations hard to use #5693

Closed wdpi closed 2 years ago

wdpi commented 2 years ago

Steps to reproduce:

  1. go to: Network → Wireless → Edit (one of your Wireless Networks) → Interface Configuration → MAC Filter
  2. set "Allow all except listed"
  3. add a MAC (probably not necessary for reproducing) in MAC-List
  4. Save
  5. Save & Apply

Actual behavior:

go to: Status/Overview/Associated Stations

The Buttons on the right side of every associated station now are not just Buttons labelled "Disconnect" but a combination of Button and Combo box roughly divided into two halves by a vertical line. The left part contains the text "Disc" while the right one is empty except a Combo box arrow close to the vertical line.

image

The Combo box contains the items "Disconnect" and "Add to Blacklist". image

Opening the Combo box is quite hard since just a relatively small area around the arrow triggers that behaviour - clicking at the most parts of the button just disconnects immediately instead of opening the Combo box. image

Expected behavior:

A Button/Combo box layout like e.g. the "Save & Apply" Button would be more clear. image

Additional Information:

luci-theme-bootstrap git-22.047.35373-cc582eb

jow- commented 2 years ago

Please attach a screenshot

wdpi commented 2 years ago

Done. I did't know it was possible and so easy.

jow- commented 2 years ago

Which version of OpenWrt is that? Did you upgrade individual LuCI components?

jow- commented 2 years ago

Was able to reproduce it. Fix pushed.

wdpi commented 2 years ago

I have openwrt-21.02.1-ath79-generic-tplink_archer-c6-v2-squashfs-factory.bin installed.

Powered by LuCI openwrt-21.02 branch (git-21.295.67054-13df80d) / OpenWrt 21.02.1 r16325-88151b8303

The problem existed in this version already, so I updated to luci-theme-bootstrap git-22.047.35373-cc582eb - which did not solve the problem.

Nothing else.

On 21.02.22 23:36, Jo-Philipp Wich wrote:

Which version of OpenWrt is that? Did you upgrade individual LuCI components?

— Reply to this email directly, view it on GitHub https://github.com/openwrt/luci/issues/5693#issuecomment-1047273396, or unsubscribe https://github.com/notifications/unsubscribe-auth/AX3J5FBP5YNN7OUU46CTS4DU4K45JANCNFSM5O7VEIMQ. Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you authored the thread.Message ID: @.***>