hnyman
commented
8 years ago I think that I spotted a major flaw in the "new" method: the definition of allowed pages are cumulative for users. One page allowed for at least one user in group "user" is allowed for all users in group "user".
I defined two limited users "koe" and "test" and allowed them different pages in the status tab. Still both saw any page that at least one of them saw:
root@OpenWrt:~# cat /etc/config/users
config user
option name 'koe'
option user_group 'user'
option shell '1'
option Status_menus 'Status_menus'
option Network_menus 'disabled'
option System_menus 'System_menus'
option system_subs 'Software'
option status_subs 'Firewall Routes'
config user
option name 'test'
option user_group 'user'
option shell '0'
option System_menus 'disabled'
option Network_menus 'Network_menus'
option network_subs 'Switch Firewall'
option Status_menus 'Status_menus'
option status_subs 'System_log Kernel_log'The rights updated ok on the fly when I adjusted rights in one firefox browser with admin rights and used one IE window as plain limited user. So, the provisioning itself worked ok, but the user just got too much rights from the other basic users.
I guess that the allowed pages provisioning should be by the user class. E.g. users or admin. And each user should belong into into exactly one group. Then this might work.
Hostle
jow-
jack338c
tcpipchip
Fire-Wrt-2016
RJRvdMeer
@Hostle has created a functional system for enabling handling multiple users in Luci.
@Hostle has actually created two alternative methods for a year-old Luci (from March 2015, CC15.05 development cycle) into his Github repo. I have imported the changes into up-to-date DD trunk and have also squashed and polished the commits for discussion purposes to have minimal diffs.
Hostle thinks that the newer method is better, so I will present that here.
Original discussion at forum: https://forum.openwrt.org/viewtopic.php?id=54593 Discussion also at: https://github.com/Hostle/luci/commit/c1ba7d780fbafba1d882e3d05ff96baeaee131f3#commitcomment-15451559
"New method":
"New" original, commits from Hostle, updated in April 2017: https://github.com/Fire-WRT/luci/commits/multi4
"New" cleaned-up version from my repo, "multi4-clean" branch, contains four squashed commits targeting LEDE & Openwrt DD trunk/master: https://github.com/hnyman/luci/commits/multi4-clean (March2018: I have rebased multi4 branch history with the LuCI of June 2017.)
Trying the code:
If you want to try the multi-user code, you can easily add my Luci repo as a remote to your own git and then pull from "multi4-clean" branch. The multi4-clean branch contains up-to-date LuCI of 26 June 2017.
I used these commands to import this to my own Openwrt build. (I also created a new branch "multiuser" at my local feed repo so that I easily push the changes aside by "git checkout master"):
Alternatively, you can download the 4 commits as patches from github and apply them manually. (just add .patch to the end of the commit's page address and you get a patch that can be download with wget.)
Identified problems/challenges:
NOTE: old, reflects 2015 observations
Screenshot from trunk Designated Driver r48235: