Closed marek22k closed 1 year ago
I think https://github.com/openwrt/luci/blob/master/applications/luci-app-babeld/root/www/luci-static/resources/babeld.js#L38 is supposed to be a table. However, div elements are used for this. Maybe that is the reason for the appearance?
For the Bootstrap and OpenWrt themes, a table actually appears.
At first it was build using the table tag (see https://github.com/openwrt/luci/pull/3927#issuecomment-615781467 ) but changed to the "common div structure" because table appears to be deprecated.
The theme does not seem to support this: https://github.com/openwrt/luci/blob/openwrt-22.03/themes/luci-theme-openwrt-2020/htdocs/luci-static/openwrt2020/cascade.css Maybe @jow- knows something about it ?
Why is table deprecated? As far as I know, the element still exists in HTML5. (https://stackoverflow.com/questions/17503456/is-it-good-to-use-tables-in-html-5)
The comment, to my understanding, gives little conclusion about the reasons why LuCi has its own table
classes instead of using native HTML elements.
Steps to reproduce:
Actual behavior:
A very ugly site. I think the whole thing is supposed to be a table, but it is not.
Expected behavior:
Something clear - for example, a table.
Additional Information:
I use the Luci Design OpenWrt2020. I have attached pictures.
OpenWrt version information from system
/etc/openwrt_release
Ping on maintainers: @JonnyTischbein @PolynomialDivision @aparcar (I am sorry if I am pinging you and you are not the maintainers, however there is nothing in the files about this and you are in the commit history).