SeimusS commented 1 year ago

Issue:

On the latest 23.05.0-rc3 the Status > Overview wont load it gives "InternalError too much recursion". Tried as well 23.05.0-rc2 this issue was not seen on this release.

I checked with other user that is running same Router and same OS version/same snapshot and he doesnt have this issue. The main difference is that I am using VLANs and several VAPs

Clearing cache and cookies doesnt help, I tried as well 3 different browsers still the same.

To be more precise on the issue, only the status/overview doesnt load "/cgi-bin/luci/admin/status/overview" 269124609-2d970d85-901f-4444-b172-36a25d56582d

Steps to reproduce:

Go to Status > Overview. Must have VLANs/VAPs

Actual behavior:

Cant load Overview in luci

Expected behavior:

Status > Overview should show general overview

Additional Information:

DISTRIB_ID='OpenWrt' DISTRIB_RELEASE='23.05.0-rc3' DISTRIB_REVISION='r23389-5deed175a5' DISTRIB_TARGET='ramips/mt7621' DISTRIB_ARCH='mipsel_24kc' DISTRIB_DESCRIPTION='OpenWrt 23.05.0-rc3 r23389-5deed175a5' DISTRIB_TAINTS=''

Logs

Output from browser:

jow- commented 1 year ago

Please provide your complete /etc/config/network and /etc/board.json files.

SeimusS commented 1 year ago

As requested by Jo:

root@ASus_OpenWRT_AP01:~# cat /etc/config/network

config interface 'loopback'
        option device 'lo'
        option proto 'static'
        option ipaddr '127.0.0.1'
        option netmask '255.0.0.0'

config globals 'globals'
        option packet_steering '1'
        option ula_prefix 'fdb6:b19f:016d::/48'

config device
        option type 'bridge'
        option name 'VLAN'
        option bridge_empty '1'
        list ports 'lan1'
        list ports 'lan2'
        list ports 'lan3'
        list ports 'VLAN.10'
        list ports 'VLAN.50'
        list ports 'VLAN.101'
        list ports 'VLAN.201'
        list ports 'VLAN.999'
        option ipv6 '0'

config bridge-vlan
        option device 'VLAN'
        option vlan '10'
        list ports 'lan1:t'
        list ports 'lan2:t'
        list ports 'lan3:t'
        list ports 'VLAN.10:t'

config bridge-vlan
        option device 'VLAN'
        option vlan '50'
        list ports 'lan1:t'
        list ports 'lan2:t'
        list ports 'lan3:t'
        list ports 'VLAN.50:t'

config bridge-vlan
        option device 'VLAN'
        option vlan '101'
        list ports 'lan1:t'
        list ports 'lan2:t'
        list ports 'lan3:t'
        list ports 'VLAN.101:t'

config bridge-vlan
        option device 'VLAN'
        option vlan '201'
        list ports 'lan1:t'
        list ports 'lan2:t'
        list ports 'lan3:t'
        list ports 'VLAN.201:t'

config bridge-vlan
        option device 'VLAN'
        option vlan '999'
        list ports 'lan1:t'
        list ports 'lan2:t'
        list ports 'lan3:t'
        list ports 'VLAN.999:t'

config interface 'VLAN10_HOST'
        option proto 'none'
        option device 'VLAN.10'

config interface 'VLAN50_CONSOLE'
        option proto 'none'
        option device 'VLAN.50'

config interface 'VLAN101_WORK'
        option proto 'none'
        option device 'VLAN.101'

config interface 'VLAN201_IOT'
        option proto 'none'
        option device 'VLAN.201'
        option delegate '0'

config interface 'VLAN999_MGMT'
        option proto 'static'
        option device 'VLAN.999'
        option ipaddr '10.0.0.152'
        option netmask '255.255.255.0'
        option gateway '10.0.0.138'
        list dns '10.0.0.14'
        option delegate '0'
        option broadcast '10.0.0.255'

root@ASus_OpenWRT_AP01:~# cat /etc/board.json
{
        "model": {
                "id": "asus,rt-ax53u",
                "name": "ASUS RT-AX53U"
        },
        "led": {
                "usb": {
                        "name": "USB",
                        "sysfs": "blue:usb",
                        "type": "usbport",
                        "ports": [
                                "usb1-port2"
                        ]
                },
                "wlan2g": {
                        "name": "WiFi 2.4GHz",
                        "sysfs": "mt76-phy0",
                        "trigger": "phy0tpt"
                },
                "wlan5g": {
                        "name": "WiFi 5GHz",
                        "sysfs": "mt76-phy1",
                        "trigger": "phy1tpt"
                }
        },
        "network": {
                "lan": {
                        "ports": [
                                "lan1",
                                "lan2",
                                "lan3"
                        ],
                        "protocol": "static"
                },
                "wan": {
                        "device": "wan",
                        "protocol": "dhcp"
                }
        },
        "system": {
                "compat_version": "1.1"
        }
}

SeimusS commented 1 year ago

Updated to 23.05.0-rc4 issue is still present.

Regards, S.

raenye commented 1 year ago

How can VLAN.10, etc., be ports of the VLAN bridge? this seems wrong... AFAICT you should remove all these from the bridge and from the bridge-vlans. Having VLAN.10 in the interface should do the trick.

SeimusS commented 1 year ago

I dont think is wrong.

This is how are TAGed VLANs created. A bridge device is created and you enable Vlan bridge filtering with specific VLANs you need + allocate them to physical interfaces.

The indivudual L2 interfaces are created into the interface is a vlan attached. This is then reused in VAPs, so each VAP has a specific VLAN TAG.

Regards, S.

raenye commented 1 year ago

Please see examples here: https://github.com/openwrt/openwrt/issues/10219

(and here for swconfig and single-port DSA: https://openwrt.org/docs/guide-user/network/vlan/switch_configuration)

SeimusS commented 1 year ago

Thanks for the links I will have a look and report back.

Regards, S.

raenye commented 1 year ago

Let me just note that the top message speaks of config that should work, and the extra bridge creation is the way to make it work for brcmfmac. Also, if you're looking for VLANs for VAPs only, consider this: https://forum.openwrt.org/t/individual-per-passphrase-wifi-vlans-using-wpa-psk-file-no-radius-required/161696/22 https://forum.openwrt.org/t/individual-per-passphrase-wifi-vlans-using-wpa-psk-file-no-radius-required/161696/27

SeimusS commented 1 year ago

So I went thru the links mentioned in your comment before. And you are right looks like mistake within the bridge-device. I did remove the VLAN listed ports from it which removed it as well from bridge-vlans. Now the Overview is working as should.

This as well now explains Why I was having the recursion error.

root@ASus_OpenWRT_AP01:~# cat /etc/config/network

config interface 'loopback'
        option device 'lo'
        option proto 'static'
        option ipaddr '127.0.0.1'
        option netmask '255.0.0.0'

config globals 'globals'
        option packet_steering '1'
        option ula_prefix 'fdb6:b19f:016d::/48'

config device
        option type 'bridge'
        option name 'VLAN'
        option bridge_empty '1'
        option ipv6 '0'
        list ports 'lan1'
        list ports 'lan2'
        list ports 'lan3'

config bridge-vlan
        option device 'VLAN'
        option vlan '10'
        list ports 'lan1:t'
        list ports 'lan2:t'
        list ports 'lan3:t'

config bridge-vlan
        option device 'VLAN'
        option vlan '50'
        list ports 'lan1:t'
        list ports 'lan2:t'
        list ports 'lan3:t'

config bridge-vlan
        option device 'VLAN'
        option vlan '101'
        list ports 'lan1:t'
        list ports 'lan2:t'
        list ports 'lan3:t'

config bridge-vlan
        option device 'VLAN'
        option vlan '201'
        list ports 'lan1:t'
        list ports 'lan2:t'
        list ports 'lan3:t'

config bridge-vlan
        option device 'VLAN'
        option vlan '999'
        list ports 'lan1:t'
        list ports 'lan2:t'
        list ports 'lan3:t'

config interface 'VLAN10_HOST'
        option proto 'none'
        option device 'VLAN.10'

config interface 'VLAN50_CONSOLE'
        option proto 'none'
        option device 'VLAN.50'

config interface 'VLAN101_WORK'
        option proto 'none'
        option device 'VLAN.101'

config interface 'VLAN201_IOT'
        option proto 'none'
        option device 'VLAN.201'
        option delegate '0'

config interface 'VLAN999_MGMT'
        option proto 'static'
        option device 'VLAN.999'
        option ipaddr '10.0.0.152'
        option netmask '255.255.255.0'
        option gateway '10.0.0.138'
        list dns '10.0.0.14'
        option delegate '0'
        option broadcast '10.0.0.255'

Let me just note that the top message speaks of config that should work, and the extra bridge creation is the way to make it work for brcmfmac. Also, if you're looking for VLANs for VAPs only, consider this: https://forum.openwrt.org/t/individual-per-passphrase-wifi-vlans-using-wpa-psk-file-no-radius-required/161696/22 https://forum.openwrt.org/t/individual-per-passphrase-wifi-vlans-using-wpa-psk-file-no-radius-required/161696/27

I will have a look on this and see if I can simplyfy the VAP per VLAN deployment

Many thanks @raenye much appriciated.

Regards, S.

openwrt / luci

[FIXed][23.05.0-rc3] ASUS RT-AX53U | Status > Overview "InternalError too much recursion" #6580

Issue:

Steps to reproduce:

Actual behavior:

Expected behavior:

Additional Information:

Logs