Commit access

[systemcrash]

There's still a bunch I don't yet know, but I'd be happy to help with some of the load in this repo.

Perhaps openwrt/openwrt at a later date although I'm still mainly just lurking/opining in there.

Ping @jow- @hnyman @Ansuel @aparcar @feckert

[stangri]

PRs by @systemcrash for convenience: https://github.com/openwrt/luci/pulls?q=is%3Apr+author%3Asystemcrash

[feckert]

I would say :+1: . But that's for @jow- to decide, as he has the admin rights.

[aparcar]

@openwrt/luci-admin ping

[stokito]

Paul @systemcrash helped me a lot and I believe he would be a great reviewer and maintainer. Mine PR were related to non critical apps like sshtunnel, tor, email, acme. Maybe we can move such apps into a separate repo with more relaxed contribution policy.

Additionally we can use .github/CODEOWNERS file where to specify maintainer names for different apps: https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners

[aparcar]

I invited @systemcrash to group with commit access to luci.git

@systemcrash thanks for your contribution and please enjoy OpenWrt

[Ansuel]

Afaik CODEOENERS is only for enterprise plan of GitHub

Il Dom 3 Dic 2023, 21:43 Paul Spooren @.***> ha scritto:

Closed #6694 https://github.com/openwrt/luci/issues/6694 as completed.

— Reply to this email directly, view it on GitHub https://github.com/openwrt/luci/issues/6694#event-11132350493, or unsubscribe https://github.com/notifications/unsubscribe-auth/AE2ZMQQLRPTJLO4YBE4I57DYHTQARAVCNFSM6AAAAAA7JNGYMGVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJRGEZTEMZVGA2DSMY . You are receiving this because you were mentioned.Message ID: @.***>

[systemcrash]

@aparcar as I have been for many years :)

@Ansuel : second paragraph (I didn't know this either):

You can define code owners in public repositories with GitHub Free and GitHub Free for organizations, and in public and private repositories with GitHub Pro, GitHub Team, GitHub Enterprise Cloud, and GitHub Enterprise Server. For more information, see "GitHub’s plans."

[Ansuel]

Oh they changed that? I remember noticing the feature but was only for paid plan... Nice! Would be good to use on packages

[systemcrash]

A code owner seems to have implications. They know the code best, but when they're busy or absent, and they're the only one who can approve, some PRs tend to hang there for a while. ☹️

Maybe openwrt will break this rule: CODEOWNERS files must be under 3 MB in size 😄

[stokito]

A CODEOWNERS seems to have implications. When they're busy, and they're the only one who can approve, some PRs tend to hang there for a while.

The CODEOWNERS will just request for a reviewer automatically. It's safe and similar to current approach of mentioning a maintainer manually to ask for a review.

The problem is that the review should be a member of the repository but also have a Write permission. Otherwise it can be used for a spam attack: you can mention anyone and they'll be annoyed by PRs.

The Write permission may allow to commit directly to a master branch. That's why the branch protection should be enabled were only maintainers can change it.

So please merge the PR #6830