luci-mod-status: syslog scroll buttons inert on iOS Safari browser

dave14305 commented 4 months ago

Steps to reproduce:

go to: Status → System Log using an iOS/iPadOS Safari browser with LuCI Bootstrap theme
Click the Scroll to tail button. Nothing happens.
Scroll manually to the bottom of the page. Click the Scroll to head button. Nothing happens.
Repeat same steps on the Kernel log page.

Actual behavior:

No scrolling

Expected behavior:

Scrolling to bottom or top of page as worked earlier in 23.05. Broken with https://github.com/openwrt/luci/commit/9370bdddaede2feeb581193158d83f5062d5a318

Additional Information:

OpenWrt version information from system /etc/openwrt_release

DISTRIB_ID='OpenWrt'
DISTRIB_RELEASE='23.05.3'
DISTRIB_REVISION='r23809-234f1a2efa'
DISTRIB_TARGET='x86/64'
DISTRIB_ARCH='x86_64'
DISTRIB_DESCRIPTION='OpenWrt 23.05.3 r23809-234f1a2efa'
DISTRIB_TAINTS=''

luci-mod-status - git-24.141.29354-5cfe7a7

systemcrash commented 4 months ago

I can at least confirm this behaviour on iOS Safari. @McGiverGim wanna take a crack at fixing?

McGiverGim commented 4 months ago

I don't have any mac/apple product. I will be out of my computer for one month more or less. I can give it a try then. I will need to install safari on my windows to reproduce it?

dave14305 commented 4 months ago

Consider using .scrollIntoView() instead of .focus(). Seems to work on iOS Safari and Windows Chrome for the current BootStrap theme.

systemcrash commented 4 months ago

@dave14305 your suggestion worked fine. Committed. Thanks!

dave14305 commented 3 months ago

@dave14305 your suggestion worked fine. Committed. Thanks!

@systemcrash will this be backported to 23.05?

systemcrash commented 3 months ago

If it wasn't already I'll go do that. Good to get it verified by others in master (where verified means it doesn't break anything else)

systemcrash commented 3 months ago

picked to 23 and 22. Thanks for the nudge @dave14305

openwrt / luci