Luci-Theme: LuCI Master 24.319.72217~9fe1e34 is no themes in the theme dropdown, APK error in installation

Daprogra2 commented 2 days ago

Is there an existing issue for this?

[X] I have searched the existing issues

screenshots or captures

LuCI Master 24.319.72217~9fe1e34 is not providing theme selections in the theme dropdown. This is preventing the any settings changes in the System Tab from being saved.

Actual behaviour

Opened System menu in LUCI
Changed router name <General Settings - Hostname>
Click Save and Apply
Received error - An error occurred while saving the form: Option "Design" contains an invalid input value. Expecting: non-empty value

Expected behaviour

Opened System menu in LUCI
Changed router name <General Settings - Hostname>
Click Save and Apply
Name Change Is Successful

Steps to reproduce

Opened System menu in LUCI
Changed router name <General Settings - Hostname>
Click Save and Apply

Additional Information

root@OpenWrt:~# cat /etc/os-release
NAME="OpenWrt"
VERSION="SNAPSHOT"
ID="openwrt"
ID_LIKE="lede openwrt"
PRETTY_NAME="OpenWrt SNAPSHOT"
VERSION_ID="snapshot"
HOME_URL="https://openwrt.org/"
BUG_URL="https://bugs.openwrt.org/"
SUPPORT_URL="https://forum.openwrt.org/"
BUILD_ID="r28085-6720c4ccba"
OPENWRT_BOARD="mediatek/filogic"
OPENWRT_ARCH="aarch64_cortex-a53"
OPENWRT_TAINTS=""
OPENWRT_DEVICE_MANUFACTURER="OpenWrt"
OPENWRT_DEVICE_MANUFACTURER_URL="https://openwrt.org/"
OPENWRT_DEVICE_PRODUCT="Generic"
OPENWRT_DEVICE_REVISION="v0"
OPENWRT_RELEASE="OpenWrt SNAPSHOT r28085-6720c4ccba"
OPENWRT_BUILD_DATE="1731585818"

LuCI Master 24.319.72217~9fe1e34

What browsers do you see the problem on?

Firefox

Relevant log output

<select id="widget.cbid.luci.cfg01e48a._mediaurlbase" class="cbi-input-select cbi-input-invalid" data-tooltip="Expecting: non-empty value" data-tooltip-style="error"></select>

Uncaught (in promise) TypeError: Option "Design" contains an invalid input value. Expecting: non-empty value
    parse http://192.168.60.1/luci-static/resources/form.js?v=24.319.72217~9fe1e34:137
    parse http://192.168.60.1/luci-static/resources/form.js?v=24.319.72217~9fe1e34:71
    parse http://192.168.60.1/luci-static/resources/form.js?v=24.319.72217~9fe1e34:47
    save http://192.168.60.1/luci-static/resources/form.js?v=24.319.72217~9fe1e34:47
    callClassMethod http://192.168.60.1/luci-static/resources/luci.js?v=24.319.72217~9fe1e34:137
    handleSave http://192.168.60.1/luci-static/resources/luci.js?v=24.319.72217~9fe1e34:147
    handleSave http://192.168.60.1/luci-static/resources/luci.js?v=24.319.72217~9fe1e34:147
    handleSaveApply http://192.168.60.1/luci-static/resources/luci.js?v=24.319.72217~9fe1e34:147
    createHandlerFn http://192.168.60.1/luci-static/resources/ui.js?v=24.319.72217~9fe1e34:360
    handleClick http://192.168.60.1/luci-static/resources/ui.js?v=24.319.72217~9fe1e34:160
    bind http://192.168.60.1/luci-static/resources/ui.js?v=24.319.72217~9fe1e34:58
    render http://192.168.60.1/luci-static/resources/ui.js?v=24.319.72217~9fe1e34:47
    render http://192.168.60.1/luci-static/resources/ui.js?v=24.319.72217~9fe1e34:157
    addFooter http://192.168.60.1/luci-static/resources/luci.js?v=24.319.72217~9fe1e34:149
    __init__ http://192.168.60.1/luci-static/resources/luci.js?v=24.319.72217~9fe1e34:147
    promise callback*__init__ http://192.168.60.1/luci-static/resources/luci.js?v=24.319.72217~9fe1e34:147
    super http://192.168.60.1/luci-static/resources/luci.js?v=24.319.72217~9fe1e34:22
    ClassConstructor http://192.168.60.1/luci-static/resources/luci.js?v=24.319.72217~9fe1e34:12
    compileClass http://192.168.60.1/luci-static/resources/luci.js?v=24.319.72217~9fe1e34:182
    promise callback*compileClass http://192.168.60.1/luci-static/resources/luci.js?v=24.319.72217~9fe1e34:178
    promise callback*require http://192.168.60.1/luci-static/resources/luci.js?v=24.319.72217~9fe1e34:184
    instantiateView http://192.168.60.1/luci-static/resources/ui.js?v=24.319.72217~9fe1e34:360
    <anonymous> http://192.168.60.1/cgi-bin/luci/admin/system/system:51
    promise callback* http://192.168.60.1/cgi-bin/luci/admin/system/system:50
luci.js:137:348
Uncaught (in promise) TypeError: Option "Design" contains an invalid input value. Expecting: non-empty value
    parse http://192.168.60.1/luci-static/resources/form.js?v=24.319.72217~9fe1e34:137
    parse http://192.168.60.1/luci-static/resources/form.js?v=24.319.72217~9fe1e34:71
    parse http://192.168.60.1/luci-static/resources/form.js?v=24.319.72217~9fe1e34:47
    save http://192.168.60.1/luci-static/resources/form.js?v=24.319.72217~9fe1e34:47
    callClassMethod http://192.168.60.1/luci-static/resources/luci.js?v=24.319.72217~9fe1e34:137
    handleSave http://192.168.60.1/luci-static/resources/luci.js?v=24.319.72217~9fe1e34:147
    handleSave http://192.168.60.1/luci-static/resources/luci.js?v=24.319.72217~9fe1e34:147
    handleSaveApply http://192.168.60.1/luci-static/resources/luci.js?v=24.319.72217~9fe1e34:147
    createHandlerFn http://192.168.60.1/luci-static/resources/ui.js?v=24.319.72217~9fe1e34:360
    handleClick http://192.168.60.1/luci-static/resources/ui.js?v=24.319.72217~9fe1e34:160
    bind http://192.168.60.1/luci-static/resources/ui.js?v=24.319.72217~9fe1e34:58
    render http://192.168.60.1/luci-static/resources/ui.js?v=24.319.72217~9fe1e34:47
    render http://192.168.60.1/luci-static/resources/ui.js?v=24.319.72217~9fe1e34:157
    addFooter http://192.168.60.1/luci-static/resources/luci.js?v=24.319.72217~9fe1e34:149
    __init__ http://192.168.60.1/luci-static/resources/luci.js?v=24.319.72217~9fe1e34:147
    promise callback*__init__ http://192.168.60.1/luci-static/resources/luci.js?v=24.319.72217~9fe1e34:147
    super http://192.168.60.1/luci-static/resources/luci.js?v=24.319.72217~9fe1e34:22
    ClassConstructor http://192.168.60.1/luci-static/resources/luci.js?v=24.319.72217~9fe1e34:12
    compileClass http://192.168.60.1/luci-static/resources/luci.js?v=24.319.72217~9fe1e34:182
    promise callback*compileClass http://192.168.60.1/luci-static/resources/luci.js?v=24.319.72217~9fe1e34:178
    promise callback*require http://192.168.60.1/luci-static/resources/luci.js?v=24.319.72217~9fe1e34:184
    instantiateView http://192.168.60.1/luci-static/resources/ui.js?v=24.319.72217~9fe1e34:360
    <anonymous> http://192.168.60.1/cgi-bin/luci/admin/system/system:51
    promise callback* http://192.168.60.1/cgi-bin/luci/admin/system/system:50
luci.js:137:348

hnyman commented 2 days ago

You may have found something.

I see the normal selection between the Bootstrap variants. But if I try to install openwrt-2020 theme, there is an error and the package does not appear into the dropdown selection list. Neither is there any trace in /etc/config/luci, although there are openwrt-2020 theme files in /overlay/upper.

The error given is:

Executing package manager

apk add luci-theme-openwrt-2020

(1/1) Installing luci-theme-openwrt-2020 (24.320.57985~1a4b6ad)
Executing luci-theme-openwrt-2020-24.320.57985~1a4b6ad.post-install
1 error; 71 MiB in 309 packages

The apk install command failed with code 1.

Looks like it fails to run the post-install actions, or something like that. The error message does not appear more clear even from ssh console with --verbose.

systemcrash commented 2 days ago

Looks like fallout from apk switchover?

Daprogra2 commented 1 day ago

I was able to install a couple of themes via LUCI but they did not show in the dropdown

hnyman commented 1 day ago

I tested a bit with r28102-65964c42f8 and noticed that

the script setting the config values to /etc/config/luci was placed into /etc/uci-defaults directory, (https://github.com/openwrt/luci/blob/master/themes/luci-theme-openwrt-2020/root/etc/uci-defaults/30_luci-theme-openwrt-2020 )
but it was not being run along the theme installation. opkg or apk should run it at installation.

When I then booted the router, the theme got changed and both themes were visible in the menu.

This is probably something that @aparcar and @Ansuel are interested, as it suggests that the apk package installation process does not currently do quite the same steps as opkg did.

hnyman commented 1 day ago

The root cause may be

some kind of incompatibility between theme packages and https://github.com/openwrt/openwrt/blob/main/package/base-files/files/lib/functions.sh , or
apk not running the default-postinst in /lib/functions.sh at all. (I tried adding debug statements there, but saw no output. Looks like that default-postinst is not reached)
cc @aparcar Any ideas?

hnyman commented 1 day ago

I created a bug report into main OpenWrt about this: https://github.com/openwrt/openwrt/issues/16987

openwrt / luci