Luci - Network switch config not viewable

shogsbro commented 8 years ago

I built LEDE trunk for my HH2B last night, with full Luci. I copied switch configuration from here, and then see a Switch menu entry under Network.

When selected, I get this Lua error:

/usr/lib/lua/luci/dispatcher.lua:460: Failed to execute cbi dispatcher target for entry '/admin/network/vlan'.
The called action terminated with an exception:
/usr/lib/lua/luci/model/cbi/admin_network/vlan.lua:276: attempt to index local 'topo' (a nil value)
stack traceback:
    [C]: in function 'assert'
    /usr/lib/lua/luci/dispatcher.lua:460: in function 'dispatch'
    /usr/lib/lua/luci/dispatcher.lua:141: in function </usr/lib/lua/luci/dispatcher.lua:140>

Here is relevant parts of /etc/config/network:

config switch 'eth0'
        option name             eth0
        option reset            1
        option enable_vlan      1

config switch_vlan              # LAN
        option vlan             1
        option device           eth0
        option ports            '1 2 3 5t'

config switch_vlan              # WAN
        option vlan             2
        option device           eth0
        option ports            '4 5t'

config switch_port
        option port             4
        option pvid             2

Output from swconfig dev eth0 show:

root@lede:~# swconfig dev eth0 show
Global attributes:
    enable_vlan: 1
Port 0:
    mib: Port 0 MIB counters
RxPacket    : 0
RxByte      : 0
TxPacket    : 0
TxByte      : 0
Collision   : 0
Error       : 0

    pvid: 0
    link: port:0 link:down
Port 1:
    mib: Port 1 MIB counters
RxPacket    : 0
RxByte      : 0
TxPacket    : 0
TxByte      : 0
Collision   : 0
Error       : 0

    pvid: 1
    link: port:1 link:down
Port 2:
    mib: Port 2 MIB counters
RxPacket    : 0
RxByte      : 0
TxPacket    : 0
TxByte      : 0
Collision   : 0
Error       : 0

    pvid: 1
    link: port:2 link:down
Port 3:
    mib: Port 3 MIB counters
RxPacket    : 0
RxByte      : 0
TxPacket    : 0
TxByte      : 0
Collision   : 0
Error       : 0

    pvid: 1
    link: port:3 link:down
Port 4:
    mib: Port 4 MIB counters
RxPacket    : 26926
RxByte      : 3160224
TxPacket    : 5867
TxByte      : 644135
Collision   : 0
Error       : 0

    pvid: 2
    link: port:4 link:up speed:100baseT full-duplex txflow rxflow auto
Port 5:
    mib: Port 5 MIB counters
RxPacket    : 5870
RxByte      : 644725
TxPacket    : 26929
TxByte      : 3160504
Collision   : 0
Error       : 0

    pvid: 0
    link: port:5 link:up speed:100baseT full-duplex txflow rxflow auto
VLAN 1:
    vid: 1
    ports: 1 2 3 5t 
VLAN 2:
    vid: 2
    ports: 4 5t

The switch configuration itself works as expected.

shogsbro commented 8 years ago

I followed the code, and see it is looking for switch info in /etc/board.json, which looks like this:

# cat /etc/board.json 
{
    "model": {
        "id": "BTHOMEHUBV2B",
        "name": "BTHOMEHUBV2B - BT Home Hub 2B"
    },
    "led": {
        "wifi": {
            "name": "wifi",
            "type": "trigger",
            "sysfs": "bthomehubv2b:blue:wireless",
            "trigger": "phy0tpt"
        },
        "internet": {
            "name": "internet",
            "type": "netdev",
            "sysfs": "bthomehubv2b:blue:broadband",
            "device": "nas0",
            "mode": "link tx rx"
        }
    },
    "network": {
        "lan": {
            "ifname": "eth0",
            "protocol": "static",
            "macaddr": "00:21:04:da:4b:98"
        },
        "wan": {
            "ifname": "nas0",
            "protocol": "pppoe",
            "macaddr": "00:21:04:da:4b:99"
        }
    },
    "dsl": {
        "atmbridge": {
            "vpi": 1,
            "vci": 32,
            "encaps": "llc",
            "payload": "bridged"
        },
        "modem": {
            "type": "adsl",
            "annex": "a",
            "firmware": "\/lib\/firmware\/adsl.bin"
        }
    }
}

This looks to stem from this changeset by @jow- in reaction to this OpenWrt bug.

I'll try to work out what populates this file (and isn't adding the switch entries required).

shogsbro commented 8 years ago

So /etc/board.json should be populated by /etc/board.d/02_network, which is missing the switch section for BTHOMEHUBV2B. Something like:

    ucidef_add_switch "switch0" \
        "1:lan:1" "2:lan:2" "3:lan:3" "4:lan:4" "5t@eth0"

I rebooted with this patch on my test router, but still see the same error. I then found this changeset by @blogic regarding /etc/board.json, and the new config_generate command to update the Luci configuration.

After saving the original files (/etc/board.json, /etc/config/network, /etc/config/system) elsewhere, I ran config_generate which regenerated those files.

Though the display looks funny (probably since the files do not match the running swconfig output), Luci no longer crashes. Woo-hoo!!!

shogsbro commented 8 years ago

It looks like the code protects itself from lacking data in /etc/board.json:

                if swc and topo then

I have not worked out how to output debugging info in LuCI code, but possibly this bug is caused by the defaulting to "eth0" at line 533 in this changeset by @jow-.

seeb73 commented 1 year ago

How to add a switch Xiaomi Redmi AC2100 Router (white)?

openwrt / luci

Luci - Network switch config not viewable #779