search

openwrt / mt76

mac80211 driver for MediaTek MT76x0e, MT76x2e, MT7603, MT7615, MT7628 and MT7688
746 stars 342 forks source link

does mt76x2_eeprom contain invalid values? #48

Open psyborg55 opened 8 years ago

psyborg55 commented 8 years ago

looking at the code i see there is quite some defines missing, and some are possibly wrong!

for example:

MT_EE_LNA_GAIN =          0x044,
MT_EE_RSSI_OFFSET_2G_0 =        0x046,
MT_EE_RSSI_OFFSET_2G_1 =        0x048,
MT_EE_RSSI_OFFSET_5G_0 =        0x04a,
MT_EE_RSSI_OFFSET_5G_1 =        0x04c,

this would mean the data for chain 0 are not read since in my factory eeprom this field is 00. it is also wrong name RSSI_OFFSET for what the driver assumes it works with but it should be renamed to LNA_GAIN

according to MT7612E EEPROM content guideline

it should be:

MT_EE_LNA_GAIN_2G =           0x044,
MT_EE_LNA_GAIN_5G_GROUP1 =      0x045,
MT_EE_RSSI_OFFSET_2G_0 =        0x046,
MT_EE_RSSI_OFFSET_2G_1 =        0x047,
MT_EE_LNA_GAIN_5G_GROUP2 =      0x049,
MT_EE_RSSI_OFFSET_5G_0 =        0x04a,
MT_EE_RSSI_OFFSET_5G_1 =        0x04b,
MT_EE_LNA_GAIN_5G_GROUP3 =      0x04d,
xavier83 commented 4 years ago

bump? where is this 'content guideline'?