openwrt / netifd

[MIRROR] OpenWrt Network interface configuration daemon
https://git.openwrt.org/?p=project/netifd.git;
20 stars 25 forks source link

system-linux: re-apply ethtool on phy attachment #30

Closed dangowrt closed 4 months ago

dangowrt commented 5 months ago

ethtool settings applied before the interface is in IFF_UP state are going to be lost when phylink is being used. This is the case with many modern NICs as well as when using SFP modules, resulting in the speed, duplex, *pause and autoneg settings not having any effect.

Reapply ethtool settings once the PHY is attached.

cdeconinck commented 4 months ago

Tested on Turris Omnia with netfid v2024-01-04 and everything works now

Without this patch, the autoneg setting on the eth2 interface was not taken into account