search

openwrt / netifd

[MIRROR] OpenWrt Network interface configuration daemon
https://git.openwrt.org/?p=project/netifd.git;
17 stars 19 forks source link

device: add support to configure eee #8

Closed rthakur33 closed 10 months ago

rthakur33 commented 1 year ago

this commit adds support for configuring eee on a device via the network uci file. option eee is added to the config device section with type as boolean to enable or disable eee.

rthakur33 commented 10 months ago

hi @jow- , all comments handled, can you please review and approve this if ok? thanks!

Ansuel commented 10 months ago

@rthakur33 can you add a commit description ?

rthakur33 commented 10 months ago

@rthakur33 can you add a commit description ?

@Ansuel , thanks for the comment, description is added to the commit and conflict with master resolved too

Ansuel commented 10 months ago

@rthakur33 sorry for asking you again but can you rework the commit description to something more like this? https://github.com/openwrt/netifd/pull/14/commits

(also make it imperative aka "Modify that to make..." instead of "This commit is to...")

Ansuel commented 10 months ago

Also this needs to be rebased

Ansuel commented 10 months ago

Also it might be a good idea to add the value in device_dump_status (needed for luci to have get the state of eee)

rthakur33 commented 10 months ago

Also it might be a good idea to add the value in device_dump_status (needed for luci to have get the state of eee)

thanks for the comment, done.

Ansuel commented 10 months ago

Thanks a lot!