search

openwrt / odhcpd

This repository is a mirror of https://git.openwrt.org/?p=project/odhcpd.git. Pull requests will be accepted which will be merged in odhcpd.git
GNU General Public License v2.0
160 stars 96 forks source link

Dhcp sntp #123

Closed davefiddes closed 5 years ago

davefiddes commented 5 years ago

This short series of changesets extends odhcpd to provide details of NTP servers for clients on the network. The configuration is very similar to DNS server addressing. I don't believe that it has any impact on routing or relaying.

dedeckeh commented 5 years ago

I'm in doubt if it's a good idea to send sntp servers by default to clients if the clients do not request the sntp server option

davefiddes commented 5 years ago

I think you are right and it doesn't seem to be the greatest idea. However it doesn't seem to be contrary to the DHCPv6 RFC and NetworkManager and LwIP stacks do not appear to tie the option requests to the responses.

I'll have a look at implementing that behaviour as long as you are happy with the general approach?

dedeckeh commented 5 years ago

I'm fine with the approach although it would be better to have logic in place which allows to define a DHCP option in an opaque way as it's not scalable to add a new config option for every DHCP option

davefiddes commented 5 years ago

I'm unlikely to get to these changes anytime soon. Closing this PR to reduce clutter.