search

openwrt / odhcpd

This repository is a mirror of https://git.openwrt.org/?p=project/odhcpd.git. Pull requests will be accepted which will be merged in odhcpd.git
GNU General Public License v2.0
162 stars 98 forks source link

ndp: answer global-addressed NS manually #143

Closed sfan5 closed 5 years ago

sfan5 commented 5 years ago

The problem is also described in the first post of https://forum.archive.openwrt.org/viewtopic.php?id=40871:

The ISP router send an NS to the global address of a host, the kernel won't route it due to link-local source. The NS go unanswered until the ISP router eventually sends the same NS as multicast. In my case this made the ISP router delay/drop packets.

dedeckeh commented 5 years ago

I understand the need to send a NA in reponse to an unicast NS but a t least it should be checked if the IPv6 address is known. In the case you're observing such unicast NS is the IPv6 address setup as a proxy IPv6 address by the NDP module ?

sfan5 commented 5 years ago

Yes, the unicast NS happens to/for addresses shown by ip -6 n s proxy. How would I check that the addr is actually set up for proxying? Does odhcpd keep an internal list?

dedeckeh commented 5 years ago

No odhcp does not keep a list; this can be checked by doing a netlink get on the neighbor proxy kernel table

dedeckeh commented 5 years ago

Looks good; can you squash both patches into one commit ? Can you also provide a SoB as described in https://openwrt.org/submitting-patches#sign_your_work ?

sfan5 commented 5 years ago

Done.

dedeckeh commented 5 years ago

The SoB needs to be your full name; can you adapt this accordingly ?

sfan5 commented 5 years ago

Has been done.

dedeckeh commented 5 years ago

Thx for the patch, pushed to master (https://git.openwrt.org/?p=project/odhcpd.git;a=commit;h=91a28e4566bdae6532d3801332bef9999f43605c)