openwrt / odhcpd

This repository is a mirror of https://git.openwrt.org/?p=project/odhcpd.git. Pull requests will be accepted which will be merged in odhcpd.git
GNU General Public License v2.0
162 stars 98 forks source link

dhcpv4: improve error when a prefix is too long #194

Closed rvandegrift closed 1 year ago

rvandegrift commented 1 year ago

If a user tries to enable dhcpv4 on an interface with a /29, odhcp won't work. The logs will only contain a message that doesn't help identify the problem. It'd be idea to support any prefix with a valid pool, but at least this would point a confused user in the right direction.

Helps improve https://github.com/openwrt/openwrt/issues/11813

Ansuel commented 1 year ago

@rvandegrift Are you still interested in this feature? Can you help me with that?

I posted some comments to this and I would need you to add a SoB tag with your real name surname and email (hope it's not a problem)

rvandegrift commented 1 year ago

@rvandegrift Are you still interested in this feature? Can you help me with that?

I posted some comments to this and I would need you to add a SoB tag with your real name surname and email (hope it's not a problem)

No problem at all - done.