search

openwrt / odhcpd

This repository is a mirror of https://git.openwrt.org/?p=project/odhcpd.git. Pull requests will be accepted which will be merged in odhcpd.git
GNU General Public License v2.0
162 stars 98 forks source link

Missing host name identifier handling (1 bug & 1 enhancement) #94

Open EricLuehrsen opened 7 years ago

EricLuehrsen commented 7 years ago

Bug: DHCPv4 lease records should all be internally consistent but change with or without hostname. Compare when odhcpd receives DHCPv6 requests without FQDN option negotiation, it will put a "-" in the name field in the lease file. This is easy to parse with scripts including LuCI. However, DHCPv4 will skip the field altogether breaking the field-structure or field-count for scripts.

Enhancement: There should be an odhcpd general option to enable fill in unnamed leases. DHCPv4 use the MAC as in unknown-010203040506 and DHCPv6 use the last 64 bits of the DUID as in unknown-0102030405060708

dedeckeh commented 7 years ago

@EricLuehrsen The bug has been fixed in commit https://git.lede-project.org/?p=project/odhcpd.git;a=commit;h=700f5abbeff4e3dcc0f6b12d4883315e2cfb9b74

EricLuehrsen commented 7 years ago

@dedeckeh thanks for that. Is this fork maintained? Or is there some preference in where to post bugs to? (should I close issue or keep as reminder to maintain here?)

dedeckeh commented 7 years ago

@EricLuehrsen Lede uses a clone of this repo (https://git.lede-project.org/project/odhcp.git) as PR to fix issues remained open. Therefore I would advice to log issues and enhancement requests in the Lede issue tracker (https://bugs.lede-project.org/)