search

openwrt / packages

Community maintained packages for OpenWrt. Documentation for submitting pull requests is in CONTRIBUTING.md
GNU General Public License v2.0
3.94k stars 3.46k forks source link

jool: Remove ethtool dependency #10534

Closed ydahhrk closed 4 years ago

ydahhrk commented 4 years ago

Maintainer: @tiagogaspar8 Environment: Don't know

Description:

This is not really a bug; it's more of a quirk.

@jirutka noticed that ethtool is listed as a dependency of Jool. I don't think this conflicts with anything, but is it really necessary?

To the best of my knowledge, Jool does not depend on ethtool in any way. Back in Jool 3, ethtool served as a GRO disabling tool, but even then it was considered accompanying software, not a dependency. GRO disabling has been rendered theoretically unnecessary as of Jool 4, and I haven't seen anyone doing it as of late. (I'm the upstream developer.)

BKPepe commented 4 years ago

Fixed by this commit https://github.com/openwrt/packages/commit/526b384503e217d428ca4bbe9b546e1653b7b117