openwrt / packages

Community maintained packages for OpenWrt. Documentation for submitting pull requests is in CONTRIBUTING.md
GNU General Public License v2.0
3.95k stars 3.46k forks source link

fwknop - /etc/init.d/fwknopd: line 11: /lib/functions/network.sh: No such file or directory #11034

Open PeteLawler opened 4 years ago

PeteLawler commented 4 years ago

Maintainer: @jp-bennett Environment: Building 19.07.0 for ath79 (though not architecture specific issue)

Description: Error thrown during build.

openwrt-imagebuilder-19.07.0-ath79-generic.Linux-x86_64/build_dir/target-mips_24kc_musl/root-ath79/etc/init.d/fwknopd: line 11: /lib/functions/network.sh: No such file or directory
./etc/init.d/fwknopd: line 11: /lib/functions/network.sh: No such file or directory
Formating code blocks by wrapping them with pairs of ```

I'm not overly familiar with the repos and how stuff is built, but a glance makes me think that it is possible that an attempted fix was made in 5a69b9c08f9bc9d5b8fd868648b418075a1057aa, however was rejected by Travis https://travis-ci.org/openwrt/packages/builds/288644851

jp-bennett commented 4 years ago

Yes, and Travis failed it for a totally unrelated build error. Thanks for reporting, I'll get this fixed.On Jan 15, 2020 10:31 PM, Peter Lawler notifications@github.com wrote:Maintainer: @jp-bennett Environment: Building 19.07.0 for ath79 (though not architecture specific issue) Description: Error thrown during build. openwrt-imagebuilder-19.07.0-ath79-generic.Linux-x86_64/build_dir/target-mips_24kc_musl/root-ath79/etc/init.d/fwknopd: line 11: /lib/functions/network.sh: No such file or directory ./etc/init.d/fwknopd: line 11: /lib/functions/network.sh: No such file or directory Formating code blocks by wrapping them with pairs of ```

I'm not overly familiar with the repos and how stuff is built, but a glance makes me think that it is possible that an attempted fix was made in 5a69b9c, however was rejected by Travis https://travis-ci.org/openwrt/packages/builds/288644851

—You are receiving this because you were mentioned.Reply to this email directly, view it on GitHub, or unsubscribe.

PeteLawler commented 4 years ago

Cheers, thanks for that. Would you like me to open a separate issue to get the package version bumped from 2.6.9 to match upstream (https://github.com/mrash/fwknop is 2.6.11) or you happy to take my mention of it in passing? ;-)

jp-bennett commented 4 years ago

On 1/15/20 11:04 PM, Peter Lawler wrote:

Cheers, thanks for that. Would you like me to open a separate issue to get the package version bumped from 2.6.9 to match upstream (https://github.com/mrash/fwknop is 2.6.11) or you happy to take my mention of it in passing? ;-)

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/openwrt/packages/issues/11034?email_source=notifications&email_token=ABK6X5YLWCYYEFMM6EEFZNLQ57TE3A5CNFSM4KHNZSOKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJCZEKY#issuecomment-574984747, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABK6X56JGV2DPX7STOEALZTQ57TE3ANCNFSM4KHNZSOA.

I also see where I did a pull request to bump it to 2.6.10, which also never got pulled. I got extremely busy with another project, and didn't follow up. Mentioning it in passing is sufficient, thanks!

lkraav commented 4 years ago

Hi all. Did anything end up happening here? I just built latest 19.07.3 image and issue subject error is still there :thinking: