Closed rogerpueyo closed 3 years ago
micmac1
commented
3 years ago Good morning,
I think this is likely due to this:
https://lists.openwrt.org/pipermail/openwrt-devel/2021-April/034651.html https://lists.openwrt.org/pipermail/openwrt-devel/2021-April/034696.html
Kind regards, Seb
rogerpueyo
commented
3 years ago Hi Seb,
Thanks for your tips. I applied your patch to the latest source and generated the SDK for ath79/mikrotik locally. Unfortunately, when building cryptodev-linux using the SDK I generated, the error persists. I wondef if I may be missing some additional step?
Kind regards, Roger
micmac1
commented
3 years ago Can you paste your steps? Also what target you selected? Maybe I find some time to try to reproduce then.
rogerpueyo
commented
3 years ago Sure! I selected the ath79/mikrotik target/subtarget, which has the broken SDK on current snapshots.
Here are the steps I followed to build the SDK locally and then try to compile cryptodev-linux with 1) ath79/generic "as is", 2) ath79/mikrotik "as is" and 3) ath79/mikrotik applying your patch. Sadly, one of them worked for me.
So that's mostly it.
micmac1
commented
3 years ago Mmh OK. When I build an SDK like this then the SDK file itself ends up 59 MByte. The SDK file from here is 100 MByte. That's likely because the way you and me compiled the SDK we didn't build all the modules. Hence the Module.symvers file in the resulting SDK will lack the symbols, naturally.
Maybe compile the SDK after selecting cryptodev linux. This way all the modules it depends on should be selected.
rogerpueyo
commented
3 years ago Hi,
You're right. I repeated the same process but, when building the SDK, I also marked kmod-crytptodev (CONFIG_PACKAGE_kmod-cryptodev=m) to be built as a module.
When your patch was applied, the SDK could produce the cryptodev-linux package afterwards:
qmp@fw:~/openwrt-ath79-mikrotik-patched/bin/targets/ath79/mikrotik/openwrt-sdk-ath79-mikrotik_gcc-8.4.0_musl.Linux-x86_64$ make -j18 package/cryptodev-linux/compile
make[1] package/cryptodev-linux/compile
make[2] -C package/toolchain clean-build
make[2] -C package/toolchain compile
make[2] -C feeds/base/package/firmware/prism54-firmware compile
make[2] -C feeds/base/package/firmware/linux-firmware clean-build
make[2] -C feeds/base/package/firmware/linux-firmware compile
make[2] -C package/kernel/linux clean-build
make[2] -C package/kernel/linux compile
make[2] -C feeds/base/package/kernel/cryptodev-linux clean-build
make[2] -C feeds/base/package/kernel/cryptodev-linux compileSuccess! Without the patch, it could not build it.
Your patch has not made it upstream. Is there anything we could to foster it?
aparcar
commented
3 years ago I'll look into this once I found a suitable laptop charger
aparcar
commented
3 years ago @micmac1 thank you very much for the patch, applied to master. I'll ask around for a backport. @rogerpueyo thanks for testing and keeping the spirits high of downstream SDK projects!
micmac1
commented
3 years ago Thanks Paul!
aparcar
commented
3 years ago @micmac1 I'm just the dude with commit access, thanks for fixing the issue
rogerpueyo
commented
3 years ago The SDKs are working correctly now. Thank you both! :-)
I was trying to build a set of packages for OpenWrt whey I realized that the ath79/mikrotik snapshot SDK fails to build the
cryptodev-linuxpackage. However, the ath79/generic and ath79/nand SDKs build it correctly.Steps to reproduce:
roger@7018:~/OpenWrt/openwrt-sdk-ath79-mikrotik_gcc-8.4.0_musl.Linux-x86_64$ ./scripts/feeds update -a; ./scripts/feeds install -aroger@7018:~/OpenWrt/openwrt-sdk-ath79-mikrotik_gcc-8.4.0_musl.Linux-x86_64$ make -j8 package/iperf3/compileThe menuconfig environment appears. To speed up things, deselect:Exit &Save.
roger@7018:~/OpenWrt/openwrt-sdk-ath79-mikrotik_gcc-8.4.0_musl.Linux-x86_64$ make -j8 package/cryptodev-linux/compileCool, let's add some verbosity:
As mentioned above, the same procedure with the ath79/generic or ath79/nand SDKs gives no problem.