openwrt / packages

Community maintained packages for OpenWrt. Documentation for submitting pull requests is in CONTRIBUTING.md
GNU General Public License v2.0
3.9k stars 3.41k forks source link

acme: Missing optional value yields shell error #15704

Open mrjoel opened 3 years ago

mrjoel commented 3 years ago

Maintainer: @tohojo Environment: multiple arch, snapshot testing

Description: If some optional config values (e.g. debug, use_staging) are entirely missing from UCI then shell comparison used results in a error. This is due to the run script using -eq numeric comparisons when string comparison using = would seem to be preferred.

stokito commented 1 month ago

There was too many changes in code and no one else complained for this so please close the issue.