openwrt / packages

Community maintained packages for OpenWrt. Documentation for submitting pull requests is in CONTRIBUTING.md
GNU General Public License v2.0
3.97k stars 3.46k forks source link

stubby: Use standard notation for IPv6 local loopback address ( ::1 instead of 0::1 ) #17252

Open shoulders opened 2 years ago

shoulders commented 2 years ago

Maintainer: @jamesmacwhite Environment:

Item | Value -- | -- Model | BT Home Hub 5A Architecture | xRX200 rev 1.2 Firmware Version | OpenWrt 21.02.1 r16325-88151b8303 / LuCI openwrt-21.02 branch git-21.295.67054-13df80d Kernel Version | 5.4.154

Description:

Within the documentation and config files of stubby and the OpenWrt instructions you use the address 0::1 for the IPv6 local loopback address (which does work) but I cannot find anywhere else that uses this form, everyone uses ::1

I think these instances should be changed to keep things easier to read unless there is a technical reason for this.

These are a few that I found

README.md (several occurances) https://github.com/openwrt/packages/blob/master/net/stubby/files/README.md

https://github.com/openwrt/packages/blob/04b82e9da01e8c067702867e3ad2a604f481b169/net/stubby/files/stubby.conf#L19

https://github.com/openwrt/packages/blob/04b82e9da01e8c067702867e3ad2a604f481b169/net/stubby/files/stubby.yml#L14

I have posted this over at getdnsapi/stubby aswell ****

jamesmacwhite commented 2 years ago

Hi. Not the maintainer I'm afraid, but submit a PR and someone with push access can help get it merged.

msvamp commented 2 years ago

This seems like a limitation in the upstream stubby:

However, no reason for this limitation is specified.

In my recent PR (#18863), I have added a note in the README about this: https://github.com/openwrt/packages/pull/18863/files#diff-19dbc41aac11b9f660a125da07966a249ce1a0407f1072ea23ac7c28efc35113R232-R234