search

openwrt / packages

Community maintained packages for OpenWrt. Documentation for submitting pull requests is in CONTRIBUTING.md
GNU General Public License v2.0
3.95k stars 3.46k forks source link

CI: Test compile builds packages changed on master #17485

Closed jefferyto closed 2 years ago

jefferyto commented 2 years ago

Maintainer: @aparcar Environment: N/A

Description:

@aparcar I reran the CI on #17442 and it built packages that are changed on master as well as the package changed in the PR (django-restframework):

2022-01-03T14:36:46.3906146Z Building mg acpica-unix adguardhome dnsproxy mwan3 stubby golang django-restframework numpy boost dtc getdns openblas 
2022-01-03T14:36:46.4032249Z ##[group]Run openwrt/gh-action-sdk@v3
2022-01-03T14:36:46.4032687Z env:
2022-01-03T14:36:46.4033028Z   BRANCH: master
2022-01-03T14:36:46.4033821Z   PACKAGES: mg acpica-unix adguardhome dnsproxy mwan3 stubby golang django-restframework numpy boost dtc getdns openblas 
2022-01-03T14:36:46.4034702Z   ARCH: arm_cortex-a9_vfpv3-d16-master
2022-01-03T14:36:46.4035173Z   FEEDNAME: packages_ci
2022-01-03T14:36:46.4035565Z ##[endgroup]

This makes the CI check slower than it needs to be (in this case much slower because of boost).

jefferyto commented 2 years ago

This is still an issue. It is taking more than 2 hours to run https://github.com/openwrt/packages/actions/runs/2227169885 and https://github.com/openwrt/packages/actions/runs/2226207780 because both are building boost, even though both PRs have nothing to do with boost, but because boost was changed on master (when compared to the PR branches).

jefferyto commented 2 years ago

Ping @neheb @BKPepe

jefferyto commented 2 years ago

I think this is a duplicate of #15267 - closing.