openwrt / packages

Community maintained packages for OpenWrt. Documentation for submitting pull requests is in CONTRIBUTING.md
GNU General Public License v2.0
3.92k stars 3.44k forks source link

igmpproxy: error in default config file #22410

Open Tom-Rune opened 10 months ago

Tom-Rune commented 10 months ago

OpenWRT 23.05.0 image: openwrt-23.05.0-mvebu-cortexa9-linksys_wrt1900acs-squashfs-factory Router: Linksys WRT1900ACSv2

I tried to enable openwrt to work with IPTV over IGMP. So I installed the igmpproxy service but had a bit of a struggle get it to working.

I eventually found an error in the default config file at /etc/config/igmpproxy Line 9 read 'list altnet 192.168.1.0/24'. I changed the line to 'list altnet 0.0.0.0/0' and rebooted the router. After which IPTV started working on my ISP-provided 'box'.

Using '0.0.0.0/0' is mentioned both is the doc for setup and a thread where someone had similar issues as I.

I think fixing this may be as simple as editing the standard config-file. I am not sure where this file resides originally, it may be a part of the igmpproxy-package or part of the router-image.

I also enabled igmp-snooping, which seemed to prevent igmp-traffic from spreading to the rest of my network(the IPTV-box is connected to my routers lan2-port using TP-cable).

Some links: https://openwrt.org/docs/guide-user/network/wan/udp_multicast https://forum.openwrt.org/t/solved-iptv-igmpproxy-and-firewall-issues/12890/41?page=2

my igmpproxy file now looks like this, only the altnet adress has been changed be me. config igmpproxy option quickleave 1

option verbose [0-3](none, minimal[default], more, maximum)

config phyint option network wan option zone wan option direction upstream list altnet 0.0.0.0/0

config phyint option network lan option zone lan option direction downstream

jmv2009 commented 10 months ago

To me opening up to 0.0.0.0/0 looks like a security issue and/or denial of service risk, as the whole world will be able to multicast to your private network. But then again, omcproxy appears to do the same. It may help a bit if your upstream iptv network are private ip addresses from your provider. That kind of protects you. (But not really: Nat != firewall, and your provider may also provide internet through those addresses.)

Tom-Rune commented 9 months ago

Are you actually opening your network to mulitcast from the whole world? Will traffic enter unless a device on the inside request a multicast stream? Pretty much what NAT do.

Also, I think most ISPs generally don't allow mulitcast in their networks, unless it has been approved by them(or they are the source)

The alternative is to manually add approved igmp-sources yourself, firewall style. That is so 1990s :p