search

openwrt / packages

Community maintained packages for OpenWrt. Documentation for submitting pull requests is in CONTRIBUTING.md
GNU General Public License v2.0
3.88k stars 3.39k forks source link

nft-qos: rm unnecessary log avoid spam #24362

Open Mosney opened 2 weeks ago

Mosney commented 2 weeks ago

Maintainer: @neheb @wulfy23 @champtar @lzto @ldir-EDB0 @rosysong

Compile tested: I think it’s don’t needed.

Run tested:

I comment out this logger line in 2 files at /etc/hotplug.d/dhcp/ on my OpenWrt, and it’s works normally.

Description:

Log DHCP info to system log is obviously unnecessary. I found some users in community also complaining about this because sometimes it leads to log spam. See: https://www.right.com.cn/forum/thread-4091545-1-1.html

Mosney commented 2 weeks ago

Log samples 


Wed May 22 01:30:13 2024 user.notice nft-qos-monitor: ACTION=remove, MACADDR=MACADDR_1, IPADDR=IPADDR_1, HOSTNAME=HOSTNAME_1
Wed May 22 01:30:13 2024 user.notice nft-qos-dynamic: ACTION=remove, MACADDR=MACADDR_1, IPADDR=IPADDR_1, HOSTNAME=HOSTNAME_1
Wed May 22 02:36:56 2024 user.notice nft-qos-monitor: ACTION=update, MACADDR=MACADDR_2, IPADDR=IPADDR_2, HOSTNAME=HOSTNAME_2
Wed May 22 02:36:56 2024 user.notice nft-qos-dynamic: ACTION=update, MACADDR=MACADDR_2, IPADDR=IPADDR_2, HOSTNAME=HOSTNAME_2
Wed May 22 02:43:32 2024 user.notice nft-qos-monitor: ACTION=update, MACADDR=MACADDR_2, IPADDR=IPADDR_2, HOSTNAME=HOSTNAME_2
Wed May 22 02:43:32 2024 user.notice nft-qos-dynamic: ACTION=update, MACADDR=MACADDR_2, IPADDR=IPADDR_2, HOSTNAME=HOSTNAME_2
Wed May 22 05:00:02 2024 user.notice nft-qos-monitor: ACTION=update, MACADDR=MACADDR_3, IPADDR=IPADDR_3, HOSTNAME=HOSTNAME_3
Wed May 22 05:00:02 2024 user.notice nft-qos-dynamic: ACTION=update, MACADDR=MACADDR_3, IPADDR=IPADDR_3, HOSTNAME=HOSTNAME_3
Wed May 22 05:00:03 2024 user.notice nft-qos-monitor: ACTION=update, MACADDR=MACADDR_3, IPADDR=IPADDR_3, HOSTNAME=HOSTNAME_3
Wed May 22 05:00:03 2024 user.notice nft-qos-dynamic: ACTION=update, MACADDR=MACADDR_3, IPADDR=IPADDR_3, HOSTNAME=HOSTNAME_3
Wed May 22 05:05:23 2024 user.notice nft-qos-monitor: ACTION=remove, MACADDR=MACADDR_4, IPADDR=IPADDR_4, HOSTNAME=HOSTNAME_4
Wed May 22 05:05:23 2024 user.notice nft-qos-dynamic: ACTION=remove, MACADDR=MACADDR_4, IPADDR=IPADDR_4, HOSTNAME=HOSTNAME_4
Wed May 22 08:30:32 2024 user.notice nft-qos-monitor: ACTION=update, MACADDR=MACADDR_5, IPADDR=IPADDR_5, HOSTNAME=HOSTNAME_5
Wed May 22 08:30:32 2024 user.notice nft-qos-dynamic: ACTION=update, MACADDR=MACADDR_5, IPADDR=IPADDR_5, HOSTNAME=HOSTNAME_5
Wed May 22 08:43:32 2024 user.notice nft-qos-monitor: ACTION=update, MACADDR=MACADDR_2, IPADDR=IPADDR_2, HOSTNAME=HOSTNAME_2
Wed May 22 08:43:33 2024 user.notice nft-qos-dynamic: ACTION=update, MACADDR=MACADDR_2, IPADDR=IPADDR_2, HOSTNAME=HOSTNAME_2
Wed May 22 10:14:54 2024 user.notice nft-qos-monitor: ACTION=update, MACADDR=MACADDR_2, IPADDR=IPADDR_2, HOSTNAME=HOSTNAME_2
Wed May 22 10:14:54 2024 user.notice nft-qos-dynamic: ACTION=update, MACADDR=MACADDR_2, IPADDR=IPADDR_2, HOSTNAME=HOSTNAME_2
Wed May 22 10:17:59 2024 user.notice nft-qos-monitor: ACTION=update, MACADDR=MACADDR_5, IPADDR=IPADDR_5, HOSTNAME=HOSTNAME_5
Wed May 22 10:18:00 2024 user.notice nft-qos-dynamic: ACTION=update, MACADDR=MACADDR_5, IPADDR=IPADDR_5, HOSTNAME=HOSTNAME_5
Wed May 22 10:53:22 2024 user.notice nft-qos-monitor: ACTION=add, MACADDR=MACADDR_4, IPADDR=IPADDR_4, HOSTNAME=HOSTNAME_4
Wed May 22 10:53:22 2024 user.notice nft-qos-dynamic: ACTION=add, MACADDR=MACADDR_4, IPADDR=IPADDR_4, HOSTNAME=HOSTNAME_4
Wed May 22 12:36:46 2024 user.notice nft-qos-monitor: ACTION=update, MACADDR=MACADDR_5, IPADDR=IPADDR_5, HOSTNAME=HOSTNAME_5
Wed May 22 12:36:47 2024 user.notice nft-qos-dynamic: ACTION=update, MACADDR=MACADDR_5, IPADDR=IPADDR_5, HOSTNAME=HOSTNAME_5
Mosney commented 1 week ago

Any maintainers who noticed this,

The PR requirements are quite strict, I tired of this. Could someone with edit permissions help by simply removing the two unnecessary log lines? Your assistance would be greatly appreciated.

: === Checking commit '228e634a6b2755998dfa4f765cf4dbb28640e33f' : Author name (Mosney) need to be your real name 'firstname lastname' : Commit subject line seems ok (nft-qos: rm unnecessary log avoid spam) : Signed-off-by is missing or doesn't match author (should be 'Signed-off-by: Mosney Mosney@users.noreply.github.com') Error: Process completed with exit code 1.

feckert commented 5 days ago

Please add a 'Signed-off-by' to your commit message.

Mosney commented 5 days ago

Please add a 'Signed-off-by' to your commit message.

Sorry, I don’t know how to do that. I committed using GitHub Desktop before. I’ll check some documentation when I have time.